C#: Use * ID for Locations in buildless. #20486
Draft
+102
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change the C# extraction to use
*
IDs for Locations. This is a recommend pre-requisite for starting the work on C# overlay support.It turns out that there is a complication in relation to the "empty" location: There is a build in assumption in the QL library that we can refer to a unique single location for representing an "empty" location. That is,
Until now the empty location piggy backed on the fact that
0
as positions) would be created on extraction.As a part of this PR we now extract a single synthetic "empty" location to be used to represent the empty location in the QL library.