Rust: Add missing model #20497
Merged
Rust: Add missing model #20497
+314
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing taint flow models for the async_std::io::read::ReadExt::read method to ensure proper dataflow analysis when calls resolve to this specific implementation rather than incorrectly resolving to similar methods from other crates.
- Adds two taint flow summary models for the
ReadExt::readmethod - Ensures dataflow detection works correctly for calls that should resolve to the async-std implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call and this call should resolve to
<_ as async_std::io::read::ReadExt>::read, but it currently also resolves incorrectly to<_ as futures_util::io::AsyncReadExt>::readand<_ as futures_lite::io::AsyncReadExt>::read(will be fixed by #20282). Flow is only detected because we have a model for<_ as futures_util::io::AsyncReadExt>::read, but we were missing a model for the actual call target, which this PR adds.