Java/Cfg: Introduce new shared CFG library and replace the Java CFG.#21290
Draft
aschackmull wants to merge 29 commits intogithub:mainfrom
Draft
Java/Cfg: Introduce new shared CFG library and replace the Java CFG.#21290aschackmull wants to merge 29 commits intogithub:mainfrom
aschackmull wants to merge 29 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aschackmull
force-pushed
the
cfg/new-shared
branch
6 times, most recently
from
f54bdf4 to
0e7c3ba
Compare
aschackmull
force-pushed
the
cfg/new-shared
branch
2 times, most recently
from
7fda944 to
d5c9063
Compare
aschackmull
force-pushed
the
cfg/new-shared
branch
2 times, most recently
from
3437f86 to
b90ee55
Compare
aschackmull
force-pushed
the
cfg/new-shared
branch
from
b90ee55 to
47a45ce
Compare
… exception precision.
…are already in place, not CFG tests.
…YieldCompletions.
aschackmull
force-pushed
the
cfg/new-shared
branch
from
36860be to
3534872
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new shared CFG library, which encapsulated the control flow semantics of the most common AST constructs. Additionally, the Java CFG is replaced with an instantiation of this new library.
Control flow semantics of individual AST nodes are given in a modular non-recursive way, which allows seamless integration of the few Java-specific control flow definitions with the shared parts by way of simple union.
Any existing Java libraries with implicit reliance on the exact structure of the CFG have been updated.
Commit-by-commit review is strongly encouraged. There are a few initial setup commits, then the big commit with the main change followed by a long tail of commits to fix various tests and dependent Java libraries.