Skip to content

Address review comments

ca2838b
Select commit
Loading
Failed to load commit list.
Open

Rust: Unify call resolution logic #21355

Address review comments
ca2838b
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Mar 13, 2026 in 8s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:actions
  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build/language:csharp

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 7 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 1659 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for self, but the QLDoc mentions selfType

Check warning on line 1695 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for borrow, or derefChain, or path, or selfPos, but the QLDoc mentions unknown

Check warning on line 3728 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Missing QLDoc for parameter Warning

The QLDoc has no documentation for ie, or path, but the QLDoc mentions usize

Check warning on line 4221 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 4223 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
.

Check warning on line 4223 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
.

Check warning on line 4223 in rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
.