Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pages: Adding note to remove default DNS records #36157

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Feb 4, 2025

Why:

Closes: #36158

What's being changed (if available, include any code snippets, screenshots, or gifs):

I set up GitHub pages for the first time and ran into issues because my DNS provider (Squarespace) automatically adds an A record and apex domain for newly created domains. After doing some research it appears this is common for many DNS providers (i.e. Wix, GoDaddy, etc.) so I figured it was worth notating to help other readers.

Feel free to move it to a different part of the page, or even incorporate it into an existing paragraph instead of my note alert--whatever you think is best!

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

Copy link

welcome bot commented Feb 4, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

👓 Previews for changed content

This comment is 🤖 automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the review server. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

…s-site/managing-a-custom-domain-for-your-github-pages-site.md
@subatoi subatoi added more-information-needed More information is needed to complete review waiting for review Issue/PR is waiting for a writer's review content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team more-information-needed More information is needed to complete review labels Feb 4, 2025
@isaacmbrown isaacmbrown added the needs SME This proposal needs review from a subject matter expert label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

…s-site/managing-a-custom-domain-for-your-github-pages-site.md
Copy link
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @internetisaiah! I got this confirmed by an SME and made a small change to match the docs tone slightly more. I'll get this merged for you now 🚀

@isaacmbrown isaacmbrown enabled auto-merge February 5, 2025 09:51
@isaacmbrown isaacmbrown added this pull request to the merge queue Feb 5, 2025
Merged via the queue into github:main with commit 7805e33 Feb 5, 2025
44 checks passed
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@internetisaiah internetisaiah deleted the patch-1 branch February 5, 2025 19:02
@internetisaiah
Copy link
Contributor Author

@isaacmbrown , awesome! thanks for getting this merged so quickly. have a great rest of your day 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Note that some DNS providers add default records
3 participants