Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated note on downloading actions #36370

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Feb 19, 2025

Why:

Closes: #36343

What's being changed (if available, include any code snippets, screenshots, or gifs):

The existing note is still correct for users of GitHub Enterprise Server, but wrong for users of Github cloud. This PR updates the note to cover the options for GitHub cloud users. See more detailed information in: #36343 (comment).

New note for Free, Pro, Team, and GitHub Enterprise Cloud versions of the docs:

Screenshot showing a preview of the note content for users of Github Cloud.

The original note is still shown for GitHub Enterprise Server versions of the docs.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the preview environment.

@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 11:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the note on downloading workflow artifacts by adding version-specific content for GitHub cloud users, while still preserving the original note for GitHub Enterprise Server users.

  • Revised note for cloud users with guidance on using tokens and run identifiers.
  • Conditional Markdown sections added to differentiate behavior based on the GitHub version.

Changes

File Description
content/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md Updated the note to include version-conditional instructions for downloading artifacts

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

content/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md:159

  • Verify that the conditional Markdown syntax (e.g., {% ifversion %} and {% elsif %} tags) integrates with the surrounding note block and renders correctly. Consider testing the final output to ensure stability across versions.
> {% ifversion fpt or ghec %}If you want to download artifacts from a different workflow or workflow run, you need to supply a token and run identifier. See [Download Artifacts from other Workflow Runs or Repositories](https://github.com/actions/download-artifact?tab=readme-ov-file#download-artifacts-from-other-workflow-runs-or-repositories) in the documentation for the download-artifact action.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

👓 How to review these changes

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server
This table is posted from the Content Changes Table Comment workflow.

🤖 This comment is automatically generated.

@felicitymay felicitymay added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Feb 19, 2025
sophietheking
sophietheking previously approved these changes Feb 19, 2025
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny nit suggestion. 🐜 🎉

…does/storing-and-sharing-data-from-a-workflow.md

Co-authored-by: Sophie <[email protected]>
@felicitymay felicitymay added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 0e3ae4b Feb 19, 2025
46 checks passed
@felicitymay felicitymay deleted the 36343-actions-artifacts-note branch February 19, 2025 15:39
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team triage Do not begin working on this issue until triaged by the team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I would like you to specify the correspondence between runner types and constraints.
2 participants