Skip to content

fix: remove unused APM constants and references#23624

Merged
pelikhan merged 4 commits intomainfrom
copilot/fix
Mar 31, 2026
Merged

fix: remove unused APM constants and references#23624
pelikhan merged 4 commits intomainfrom
copilot/fix

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

APM (Agent Package Manager) is no longer used, so all related constants and references have been removed.

Changes

  • Removed DefaultAPMVersion and DefaultAPMActionVersion from pkg/constants/constants.go
  • Removed the APM version extraction variables and the "Check microsoft/APM release" / "Check microsoft/apm-action release" steps from .github/workflows/ci.yml
  • Removed all APM references from .github/workflows/cli-version-checker.md (description, version sources, release notes instructions, and guidelines)
  • Recompiled .github/workflows/cli-version-checker.lock.yml to reflect the above changes

Copilot AI and others added 2 commits March 31, 2026 02:29
@pelikhan pelikhan marked this pull request as ready for review March 31, 2026 02:40
Copilot AI review requested due to automatic review settings March 31, 2026 02:41
const AWFDefaultLogLevel = "info"

// DefaultAPMVersion is the default version of the microsoft/APM package manager
const DefaultAPMVersion Version = "v0.8.6"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot delete the APM constants, not used anymore.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in a425103 — removed both DefaultAPMVersion and DefaultAPMActionVersion from constants.go and also cleaned up the corresponding extraction variables and check steps in ci.yml.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes CI failures in the “Integration Release Availability” job by introducing missing APM version constants that the workflow extracts from pkg/constants/constants.go.

Changes:

  • Add DefaultAPMVersion and DefaultAPMActionVersion constants to pkg/constants/constants.go.
  • Update daily-doc-updater.lock.yml cache key prefix and extend guard list parsing/config to include trusted-users.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/constants/constants.go Adds missing exported APM-related default version constants used by CI extraction/grepping.
.github/workflows/daily-doc-updater.lock.yml Updates cache key prefix and wires trusted-users guard list parsing into MCP server guard policy config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 389 to +393
- name: Parse integrity filter lists
id: parse-guard-vars
env:
GH_AW_BLOCKED_USERS_VAR: ${{ vars.GH_AW_GITHUB_BLOCKED_USERS || '' }}
GH_AW_TRUSTED_USERS_VAR: ${{ vars.GH_AW_GITHUB_TRUSTED_USERS || '' }}
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description only mention adding missing APM constants, but this workflow lock file also changes the cache key prefix and introduces trusted-user guard list plumbing. Please either update the PR description to cover these workflow changes (and why they’re needed) or split them into a separate PR to keep the fix scoped.

Copilot uses AI. Check for mistakes.
Comment on lines +398 to +401
// DefaultAPMVersion is the default version of the microsoft/APM package manager
const DefaultAPMVersion Version = "v0.8.6"

// DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with existing docs (e.g., .github/workflows/shared/apm.md refers to “APM (Agent Package Manager)”), consider adjusting these new comments to use the same expansion (“APM (Agent Package Manager)”) so readers don’t confuse it with generic APM tooling.

Suggested change
// DefaultAPMVersion is the default version of the microsoft/APM package manager
const DefaultAPMVersion Version = "v0.8.6"
// DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action
// DefaultAPMVersion is the default version of the microsoft/APM (Agent Package Manager) package manager
const DefaultAPMVersion Version = "v0.8.6"
// DefaultAPMActionVersion is the default version of the microsoft/apm-action (Agent Package Manager) GitHub Action

Copilot uses AI. Check for mistakes.
Copilot AI changed the title fix: add missing DefaultAPMVersion and DefaultAPMActionVersion constants fix: remove unused DefaultAPMVersion and DefaultAPMActionVersion constants Mar 31, 2026
Copilot AI requested a review from pelikhan March 31, 2026 02:46
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot

  • remove apm version checkout in cli version checker agentic workflow
  • review comments

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 31, 2026

@copilot

  • remove apm version checkout in cli version checker agentic workflow
  • review comments

Done in 1795483 — removed all APM references from cli-version-checker.md (description, version sources, release notes section, and guidelines) and recompiled the lock file.

Copilot AI changed the title fix: remove unused DefaultAPMVersion and DefaultAPMActionVersion constants fix: remove unused APM constants and references Mar 31, 2026
@pelikhan pelikhan merged commit fdfcfd9 into main Mar 31, 2026
82 checks passed
@pelikhan pelikhan deleted the copilot/fix branch March 31, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants