fix: remove unused APM constants and references#23624
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/219f8782-f4c2-4f91-bb26-d762b18b432d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…onstants.go Agent-Logs-Url: https://github.com/github/gh-aw/sessions/219f8782-f4c2-4f91-bb26-d762b18b432d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pkg/constants/constants.go
Outdated
| const AWFDefaultLogLevel = "info" | ||
|
|
||
| // DefaultAPMVersion is the default version of the microsoft/APM package manager | ||
| const DefaultAPMVersion Version = "v0.8.6" |
There was a problem hiding this comment.
@copilot delete the APM constants, not used anymore.
There was a problem hiding this comment.
Done in a425103 — removed both DefaultAPMVersion and DefaultAPMActionVersion from constants.go and also cleaned up the corresponding extraction variables and check steps in ci.yml.
There was a problem hiding this comment.
Pull request overview
Fixes CI failures in the “Integration Release Availability” job by introducing missing APM version constants that the workflow extracts from pkg/constants/constants.go.
Changes:
- Add
DefaultAPMVersionandDefaultAPMActionVersionconstants topkg/constants/constants.go. - Update
daily-doc-updater.lock.ymlcache key prefix and extend guard list parsing/config to includetrusted-users.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pkg/constants/constants.go |
Adds missing exported APM-related default version constants used by CI extraction/grepping. |
.github/workflows/daily-doc-updater.lock.yml |
Updates cache key prefix and wires trusted-users guard list parsing into MCP server guard policy config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Parse integrity filter lists | ||
| id: parse-guard-vars | ||
| env: | ||
| GH_AW_BLOCKED_USERS_VAR: ${{ vars.GH_AW_GITHUB_BLOCKED_USERS || '' }} | ||
| GH_AW_TRUSTED_USERS_VAR: ${{ vars.GH_AW_GITHUB_TRUSTED_USERS || '' }} |
There was a problem hiding this comment.
The PR title/description only mention adding missing APM constants, but this workflow lock file also changes the cache key prefix and introduces trusted-user guard list plumbing. Please either update the PR description to cover these workflow changes (and why they’re needed) or split them into a separate PR to keep the fix scoped.
pkg/constants/constants.go
Outdated
| // DefaultAPMVersion is the default version of the microsoft/APM package manager | ||
| const DefaultAPMVersion Version = "v0.8.6" | ||
|
|
||
| // DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action |
There was a problem hiding this comment.
For consistency with existing docs (e.g., .github/workflows/shared/apm.md refers to “APM (Agent Package Manager)”), consider adjusting these new comments to use the same expansion (“APM (Agent Package Manager)”) so readers don’t confuse it with generic APM tooling.
| // DefaultAPMVersion is the default version of the microsoft/APM package manager | |
| const DefaultAPMVersion Version = "v0.8.6" | |
| // DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action | |
| // DefaultAPMVersion is the default version of the microsoft/APM (Agent Package Manager) package manager | |
| const DefaultAPMVersion Version = "v0.8.6" | |
| // DefaultAPMActionVersion is the default version of the microsoft/apm-action (Agent Package Manager) GitHub Action |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/bb820205-ac0e-4075-8643-2a0a90f73d5f Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2f0606c5-571c-482c-afe8-51dcc785eea2 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
APM (Agent Package Manager) is no longer used, so all related constants and references have been removed.
Changes
DefaultAPMVersionandDefaultAPMActionVersionfrompkg/constants/constants.go.github/workflows/ci.yml.github/workflows/cli-version-checker.md(description, version sources, release notes instructions, and guidelines).github/workflows/cli-version-checker.lock.ymlto reflect the above changes