Skip to content

fix: revert minting tokens for mcp-servers github-app from activation job back to agent job#24600

Merged
pelikhan merged 1 commit intomainfrom
copilot/revert-minting-tokens
Apr 4, 2026
Merged

fix: revert minting tokens for mcp-servers github-app from activation job back to agent job#24600
pelikhan merged 1 commit intomainfrom
copilot/revert-minting-tokens

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 4, 2026

Copilot AI requested a review from pelikhan April 4, 2026 22:35
@pelikhan pelikhan marked this pull request as ready for review April 4, 2026 22:37
Copilot AI review requested due to automatic review settings April 4, 2026 22:37
@pelikhan pelikhan merged commit 2248d44 into main Apr 4, 2026
2 checks passed
@pelikhan pelikhan deleted the copilot/revert-minting-tokens branch April 4, 2026 22:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the generated workflow lock files for Copilot token audit/optimizer to match the current compiled workflow behavior, including propagating setup trace IDs across jobs for OTLP correlation.

Changes:

  • Add setup-trace-id as an output from activation and agent jobs (sourced from the ./actions/setup step output).
  • Pass job-name into ./actions/setup and propagate trace-id from activation into downstream jobs’ setup steps.
  • Expand needs: on downstream jobs to include activation where required to access needs.activation.outputs.setup-trace-id.
Show a summary per file
File Description
.github/workflows/copilot-token-optimizer.lock.yml Adds setup trace-id output and wires cross-job trace propagation via ./actions/setup.
.github/workflows/copilot-token-audit.lock.yml Same trace-id output + propagation updates, plus needs: adjustments to access activation outputs.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment on lines 72 to +77
outputs:
comment_id: ""
comment_repo: ""
lockdown_check_failed: ${{ steps.generate_aw_info.outputs.lockdown_check_failed == 'true' }}
model: ${{ steps.generate_aw_info.outputs.model }}
setup-trace-id: ${{ steps.setup.outputs.trace-id }}
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title references reverting GitHub MCP App token minting, but the actual diff here only adds OTLP setup trace-id propagation (setup-trace-id output + passing trace-id into ./actions/setup). Consider updating the PR title (and/or description) to reflect the actual scope to avoid confusion for reviewers and release notes.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants