Implement discussion outcome evaluators and sync security architecture evidence

actions/setup/js/evaluate_outcomes.cjs

@@ -699,6 +699,168 @@ function evaluateClosePullRequest(item, defaultRepo, api = ghAPI, nowMs = Date.n
   return out;
 }
 
+/**
+ * Evaluate `close_discussion`.
+ * @param {any} item
+ * @param {string} defaultRepo
+ * @param {(endpoint: string) => any} api
+ * @param {number} nowMs
+ * @returns {EvalResult}
+ */
+function evaluateCloseDiscussion(item, defaultRepo, api = ghAPI, nowMs = Date.now()) {
+  const repo = getItemRepo(item, defaultRepo);
+  const number = getItemNumber(item);
+  const timestamp = item.timestamp || "";
+  /** @type {EvalResult} */
+  const out = {
+    result: "unknown",
+    outcome_status: "unknown",
+    evidence_strength: "weak",
+    signal: "unknown",
+    detail: "",
+    resolution_sec: null,
+    pending_age_sec: null,
+    review_comments: null,
+    changed_files: null,
+    additions: null,
+    deletions: null,
+    reactions_total: null,
+    reactions_positive: null,
+    reactions_negative: null,
+    comments: null,
+    zero_touch: false,
+  };
+
+  if (!repo || !number) {
+    out.detail = "missing discussion reference";
+    return out;
+  }
+
+  const discussion = api(`repos/${repo}/discussions/${number}`);
+  if (!discussion || (typeof discussion.state !== "string" && typeof discussion.closed !== "boolean")) {
+    out.detail = "api error";
+    setPendingAge(out, timestamp, nowMs);
+    return out;
+  }
+
+  out.comments = typeof discussion.comments === "number" ? discussion.comments : null;
+  if (discussion.reactions && typeof discussion.reactions === "object") {
+    const summary = summarizeReactions(discussion.reactions);
+    out.reactions_total = summary.total;
+    out.reactions_positive = summary.positive;
+    out.reactions_negative = summary.negative;
+  }
+
+  const isClosed = discussion.closed === true || String(discussion.state || "").toLowerCase() === "closed";
+  if (isClosed) {
+    out.result = "accepted";
+    out.outcome_status = "accepted";
+    out.evidence_strength = "strong";
+    out.signal = "closed";
+    out.detail = "closed";
+    if (discussion.created_at && discussion.closed_at) {
+      out.resolution_sec = secondsBetween(discussion.created_at, discussion.closed_at);
+    }
+    return out;
+  }
+
+  out.result = "rejected";
+  out.outcome_status = "rejected";
+  out.evidence_strength = "strong";
+  out.signal = "not_closed";
+  out.detail = "not_closed";
+  return out;
+}
+
+/**
+ * Evaluate `create_discussion`.
+ * @param {any} item
+ * @param {string} defaultRepo
+ * @param {(endpoint: string) => any} api
+ * @param {number} nowMs
+ * @returns {EvalResult}
+ */
+function evaluateCreateDiscussion(item, defaultRepo, api = ghAPI, nowMs = Date.now()) {
+  const repo = getItemRepo(item, defaultRepo);
+  const number = getItemNumber(item);
+  const timestamp = item.timestamp || "";
+  /** @type {EvalResult} */
+  const out = {
+    result: "unknown",
+    outcome_status: "unknown",
+    evidence_strength: "weak",
+    signal: "unknown",
+    detail: "",
+    resolution_sec: null,
+    pending_age_sec: null,
+    review_comments: null,
+    changed_files: null,
+    additions: null,
+    deletions: null,
+    reactions_total: null,
+    reactions_positive: null,
+    reactions_negative: null,
+    comments: null,
+    zero_touch: false,
+  };
+
+  if (!repo || !number) {
+    out.detail = "missing discussion reference";
+    return out;
+  }
+
+  const discussion = api(`repos/${repo}/discussions/${number}`);
+  if (!discussion) {
+    out.detail = "api error";
+    setPendingAge(out, timestamp, nowMs);
+    return out;
+  }
+
+  out.comments = typeof discussion.comments === "number" ? discussion.comments : null;
+  if (discussion.reactions && typeof discussion.reactions === "object") {
+    const summary = summarizeReactions(discussion.reactions);
+    out.reactions_total = summary.total;
+    out.reactions_positive = summary.positive;
+    out.reactions_negative = summary.negative;
+  }
+
+  const answered = discussion.answer_chosen_at != null || discussion.answer != null || discussion.answered === true;
+  if (answered) {
+    out.result = "accepted";
+    out.outcome_status = "accepted";
+    out.evidence_strength = "strong";
+    out.signal = "answered";
+    out.detail = "answered";
+    return out;
+  }
+
+  if (discussion.locked === true) {
+    out.result = "rejected";
+    out.outcome_status = "rejected";
+    out.evidence_strength = "strong";
+    out.signal = "locked";
+    out.detail = "locked";
+    return out;
+  }
+
+  if (typeof out.comments === "number" && out.comments > 0) {
+    out.result = "accepted";
+    out.outcome_status = "accepted";
+    out.evidence_strength = "medium";
+    out.signal = "engaged";
+    out.detail = "has replies";
+    return out;
+  }
+
+  out.result = "ignored";
+  out.outcome_status = "ignored";
+  out.evidence_strength = "medium";
+  out.signal = "no_engagement";
+  out.detail = "no replies";
+  setPendingAge(out, timestamp, nowMs);
+  return out;
+}
+
 /**
  * Normalize legacy result/detail pairs into the shared outcome model.
  * @param {string} result
@@ -797,7 +959,7 @@ function normalizeOutcome(result, detail) {
 function getItemNumber(item) {
   if (typeof item.number === "number" && Number.isFinite(item.number)) return item.number;
   const url = item.url || "";
-  const issueMatch = url.match(/\/(?:issues|pull)\/(\d+)/);
+  const issueMatch = url.match(/\/(?:issues|pull|discussions)\/(\d+)/);
   if (issueMatch) return Number(issueMatch[1]);
   return null;
 }
@@ -1370,6 +1532,12 @@ function evaluateItem(item, defaultRepo, apiOrOptions) {
   if (type === "close_pull_request") {
     return evaluateClosePullRequest(item, defaultRepo, ghAPIFn, nowMs);
   }
+  if (type === "close_discussion") {
+    return evaluateCloseDiscussion(item, defaultRepo, ghAPIFn, nowMs);
+  }
+  if (type === "create_discussion") {
+    return evaluateCreateDiscussion(item, defaultRepo, ghAPIFn, nowMs);
+  }
   if (type === "create_issue") {
     return evaluateCreateIssue(item, itemRepo, timestamp, out, ghAPIFn, nowMs);
   }
@@ -2127,6 +2295,8 @@ module.exports = {
   evaluateAddLabels,
   evaluateCloseIssue,
   evaluateClosePullRequest,
+  evaluateCloseDiscussion,
+  evaluateCreateDiscussion,
   evaluateCreatePullRequestOutcome,
   evaluatePushToPullRequestBranchOutcome,
   normalizeOutcome,

actions/setup/js/evaluate_outcomes.test.cjs

@@ -1028,6 +1028,159 @@ describe("evaluate_outcomes create_pull_request evaluator", () => {
   });
 });
 
+describe("evaluate_outcomes discussion evaluators", () => {
+  it("classifies closed discussions as accepted", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/11": {
+        state: "closed",
+        closed: true,
+        comments: 2,
+        created_at: "2026-05-20T00:00:00Z",
+        closed_at: "2026-05-21T00:00:00Z",
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "close_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/11",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("accepted");
+    expect(result.detail).toBe("closed");
+    expect(result.signal).toBe("closed");
+  });
+
+  it("classifies reopened discussions as rejected", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/12": {
+        state: "open",
+        closed: false,
+        comments: 1,
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "close_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/12",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("rejected");
+    expect(result.detail).toBe("not_closed");
+    expect(result.signal).toBe("not_closed");
+  });
+
+  it("classifies answered discussions as accepted", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/13": {
+        state: "open",
+        comments: 0,
+        answer_chosen_at: "2026-05-21T00:00:00Z",
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "create_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/13",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("accepted");
+    expect(result.detail).toBe("answered");
+    expect(result.signal).toBe("answered");
+  });
+
+  it("classifies discussions with replies as accepted", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/14": {
+        state: "open",
+        comments: 3,
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "create_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/14",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("accepted");
+    expect(result.detail).toBe("has replies");
+    expect(result.signal).toBe("engaged");
+  });
+
+  it("classifies locked discussions as rejected", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/15": {
+        state: "open",
+        comments: 0,
+        locked: true,
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "create_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/15",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("rejected");
+    expect(result.detail).toBe("locked");
+    expect(result.signal).toBe("locked");
+  });
+
+  it("classifies unengaged discussions as ignored", () => {
+    const ghAPI = mockAPI({
+      "repos/owner/repo/discussions/16": {
+        state: "open",
+        comments: 0,
+        locked: false,
+      },
+    });
+
+    const result = evaluateItem(
+      {
+        type: "create_discussion",
+        repo: "owner/repo",
+        url: "https://github.com/owner/repo/discussions/16",
+        timestamp: "2026-05-20T00:00:00Z",
+      },
+      "owner/repo",
+      { ghAPI }
+    );
+
+    expect(result.result).toBe("ignored");
+    expect(result.detail).toBe("no replies");
+    expect(result.signal).toBe("no_engagement");
+  });
+});
+
 describe("evaluate_outcomes push_to_pull_request_branch evaluator", () => {
   beforeEach(() => {
     vi.useFakeTimers();