Skip to content

[log] Add debug logging to workflow and CLI helpers#46124

Merged
pelikhan merged 2 commits into
mainfrom
add-debug-logging-workflow-cli-3b1a8e75848a6ffd
Jul 17, 2026
Merged

[log] Add debug logging to workflow and CLI helpers#46124
pelikhan merged 2 commits into
mainfrom
add-debug-logging-workflow-cli-3b1a8e75848a6ffd

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds namespaced debug logging to four packages using the existing pkg/logger infrastructure. No logic changes.

Changes

File Logger namespace Log points added
pkg/cli/doctor_command.go cli:doctor_command Auth-path entry; repo-diagnostics entry with repo and owner-type
pkg/workflow/compiler_yaml_normalize.go workflow:compiler_yaml_normalize normalizeBlankLines entry (byte count); all-blank early-return; normalized output size
pkg/workflow/compiler_yaml_policy.go workflow:compiler_yaml_policy Strict-mode source (CLI flag / frontmatter / default); --approve disabling safe-update
pkg/workflow/frontmatter_trigger_helpers.go workflow:frontmatter_trigger_helpers Deployment-status state validation loop count + each rejected value; workflow-run conclusion loop count + each rejected value

Implementation notes

  • Each file declares one package-level logger.New("<namespace>") variable.
  • All log calls use Print / Printf; no new dependencies beyond pkg/logger.
  • No behavioural changes; all additions are purely observability.

Commits

  • 00698c230 Add debug logging to workflow and CLI helpers
  • 34db7d0bd Plan: triage maintainer feedback and validations

Generated by PR Description Updater for #46124 · 26.9 AIC · ⌖ 5.02 AIC · ⊞ 4.7K ·

Add namespaced debug loggers to four previously un-instrumented files,
following the existing logger.New("pkg:filename") convention. All log
arguments are pre-computed, side-effect-free values.

- workflow/frontmatter_trigger_helpers: log deployment_status/workflow_run
  condition building and rejected invalid state/conclusion values
- workflow/compiler_yaml_policy: log strict-mode and safe-update decisions
- workflow/compiler_yaml_normalize: log entry/exit (input/output sizes,
  all-blank case) outside the hot loop
- cli/doctor_command: log which diagnostic path (auth vs repository) runs

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added automation enhancement New feature or request labels Jul 17, 2026
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, review the latest maintainer feedback, and rerun checks once updated.

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · 17.1 AIC · ⌖ 6.79 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, review the latest maintainer feedback, and rerun checks once updated.

Generated by [👨🍳 PR Sous Chef](https://github.com/github/gh-aw/actions/runs/...

Done on 34db7d0.

I ran pr-finisher and re-triaged this PR:

  • No unresolved in-scope review threads/comments were found.
  • Re-ran local checks: make fmt, make lint, make test-unit, make test, and make recompile (and reverted unrelated generated lockfile churn).
  • Latest GitHub Actions runs on this head are action_required with no jobs started (0 failed jobs), so CI on this head still needs a maintainer-triggered rerun.

Copilot AI requested a review from gh-aw-bot July 17, 2026 05:22
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, review the latest maintainer feedback, address any unresolved review comments, and rerun checks once updated.

Generated by 👨‍🍳 PR Sous Chef · 7.43 AIC · ⌖ 7.38 AIC · ⊞ 7.5K ·
Comment /souschef to run again

@pelikhan
pelikhan merged commit 204195a into main Jul 17, 2026
1 check failed
@pelikhan
pelikhan deleted the add-debug-logging-workflow-cli-3b1a8e75848a6ffd branch July 17, 2026 06:05
Copilot stopped work on behalf of gh-aw-bot due to an error July 17, 2026 06:06
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.82.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants