[eslint-miner] feat(eslint): add prefer-core-logging rule by github-actions[bot] · Pull Request #46195 · github/gh-aw

github-actions · 2026-07-17T09:36:43Z

Summary

Adds a new prefer-core-logging ESLint rule to eslint-factory that flags console.* calls and suggests replacing them with @actions/core logging equivalents (core.info, core.error, core.warning, core.debug). The rule is unconditional — it fires regardless of whether core is in scope — because global.core is always available via shim.cjs in Node.js context and via github-script in Actions context.

Existing console.* calls in actions/setup/js are migrated to core.* as part of this PR.

Changes

New ESLint rule: `prefer-core-logging`

File	Change
`eslint-factory/src/rules/prefer-core-logging.ts`	New rule implementation (77 lines). Maps `console.log/info → core.info`, `console.warn → core.warning`, `console.error → core.error`, `console.debug → core.debug`. Provides auto-fix suggestion for each violation.
`eslint-factory/src/rules/prefer-core-logging.test.ts`	New test file (192 lines) using vitest + ESLint `RuleTester`. Covers valid `core.*` calls, all four method mappings, multi-arg calls, function-parameter `core`, and metadata assertions.
`eslint-factory/src/index.ts`	Registers `preferCoreLoggingRule` in the plugin rules map.
`eslint-factory/eslint.config.cjs`	Enables rule at `warn` severity.

Migration: `console.` → `core.` in `actions/setup/js`

File	Change
`actions/setup/js/generate_usage_activity_summary.cjs`	Adds `require("./shim.cjs")`; replaces `console.log(outputPath)` with `core.info(outputPath)`.
`actions/setup/js/generate_workflow_overview.cjs`	Replaces `console.log("Generated workflow overview...")` with `core.info(...)`.
`actions/setup/js/generate_workflow_overview.test.cjs`	Updates assertion from `console.log` spy to `mockCore.info` assertion.
`actions/setup/js/merge_remote_agent_github_folder.cjs`	Adds `require("./shim.cjs")`; removes inline fallback `coreObj` shim (~13 lines); replaces all `coreObj.` calls with direct `core.` calls.

Other fixes

File	Change
`Makefile` (`test-impacted-js`)	Fixes `cd` drift: captures `ROOT=$(pwd)` before conditional directory changes so both `actions/setup/js` and `eslint-factory` test invocations use absolute paths. Previously the second `cd` would fail silently if both conditions were true.
`.github/workflows/agentic-auto-upgrade.yml`	Adjusts cron schedule from Saturday 04:11 to Friday 03:21.

Motivation

@actions/core logging integrates with the GitHub Actions annotation system: core.error and core.warning produce file annotations visible in the PR UI and workflow summary; console.* does not. Enforcing core.* via a lint rule ensures consistent structured output across all actions/setup/js scripts.

The shim.cjs module makes global.core available when scripts run as plain Node.js processes (e.g., in tests or local invocations), removing the need for per-file fallback shims.

References: §29644361914

Generated by PR Description Updater for #46195 · 64.5 AIC · ⌖ 5.8 AIC · ⊞ 4.7K · ◷

Adds a new ESLint rule that flags console.log/error/warn/debug calls in scopes where an @actions/core alias (core / coreObj) is available. Rationale: - console.* bypasses GitHub Actions' secret masking: values passed to console.* are emitted verbatim to the workflow log, without the redaction that core.info/error/warning/debug applies. - core logging integrates with the Actions annotation system (error annotations, folded groups, etc.) while console.* does not. - The pattern appears in 5 locations in actions/setup/js, e.g. generate_workflow_overview.cjs:38 and merge_remote_agent_github_folder.cjs. Rule details: - Only flags when a CORE_ALIASES binding (core / coreObj) is in scope, preventing false positives in plain scripts that don't use @actions/core. - Covers: console.log → core.info, console.error → core.error, console.warn → core.warning, console.debug → core.debug, console.info → core.info. - Provides an auto-fix suggestion for each violation. - 11 unit tests (all passing). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

pelikhan · 2026-07-17T11:28:41Z

@copiliot always favor using core.... since we have a shim.cjs file to also support node.js context.

pelikhan · 2026-07-17T11:28:55Z

@copilot always favor using core.... since we have a shim.cjs file to also support node.js context.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

…n setup/js The shim.cjs provides global.core in all Node.js contexts, so console.* should never be used — remove hasCoreInScope() scope restriction from the rule and fix all console.* calls in the files mentioned in the PR. Changes: - prefer-core-logging.ts: remove hasCoreInScope() function and check; flag all console.* calls unconditionally; update description/suggestion message to reflect global.core availability via shim.cjs - prefer-core-logging.test.ts: update formerly-valid cases to expect errors; add suggestions to new invalid test cases (11 tests still pass) - generate_workflow_overview.cjs: console.log → core.info (core is a param) - generate_usage_activity_summary.cjs: require shim.cjs + console.log → core.info - merge_remote_agent_github_folder.cjs: require shim.cjs; remove local coreObj fallback that used console.*; replace all coreObj.* → core.* Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-17T11:49:40Z

@copilot always favor using core.... since we have a shim.cjs file to also support node.js context.

Done in commit feat(eslint): make prefer-core-logging unconditional; fix console.* in setup/js.

Removed the hasCoreInScope() scope restriction from the prefer-core-logging rule — it now flags all console.* calls unconditionally, since shim.cjs provides global.core in every Node.js context.
Fixed merge_remote_agent_github_folder.cjs: added require("./shim.cjs") and removed the local coreObj fallback that used console.*; replaced all coreObj.* → core.*.
Fixed generate_workflow_overview.cjs: console.log(...) → core.info(...).
Fixed generate_usage_activity_summary.cjs: added require("./shim.cjs") and changed console.log(outputPath) → core.info(outputPath).

github-actions · 2026-07-18T00:58:31Z

🤖 PR Triage

Field	Value
Category	feature
Risk	🟡 medium
Priority Score	52/100
Score Breakdown	impact: 25, urgency: 15, quality: 12
Action	`batch_review`

Adds new ESLint miner rule prefer-core-logging. Medium-risk new linter feature addition.

Batch: pr-batch:linter-additions (groups with #46289)

Generated by 🔧 PR Triage Agent · 52.2 AIC · ⌖ 6.84 AIC · ⊞ 5.6K · ◷

Copilot

Pull request overview

Adds an ESLint rule promoting @actions/core logging in setup scripts.

Changes:

Implements and registers prefer-core-logging with tests.
Migrates several scripts from console logging to core logging.
Regenerates the auto-upgrade schedule.

Show a summary per file

File	Description
`eslint-factory/src/rules/prefer-core-logging.ts`	Implements detection and suggestions.
`eslint-factory/src/rules/prefer-core-logging.test.ts`	Tests rule behavior.
`eslint-factory/src/index.ts`	Registers the rule.
`eslint-factory/eslint.config.cjs`	Enables the rule as a warning.
`actions/setup/js/merge_remote_agent_github_folder.cjs`	Uses shim-backed core logging.
`actions/setup/js/generate_workflow_overview.cjs`	Replaces console logging with `core.info`.
`actions/setup/js/generate_usage_activity_summary.cjs`	Uses shim-backed `core.info`.
`.github/workflows/agentic-auto-upgrade.yml`	Updates the generated weekly schedule.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (2)

eslint-factory/src/rules/prefer-core-logging.ts:69

This replacement does not preserve multi-argument console calls. @actions/core logging methods consume one message, so console.log("value:", someVar) becomes core.info("value:", someVar) and silently drops someVar. Do not offer the suggestion when there is not exactly one argument (or explicitly combine the arguments into one equivalent message).

                return fixer.replaceText(node, `${replacement}(${argsText})`);

eslint-factory/src/rules/prefer-core-logging.ts:42

The diagnostic repeats the incorrect assertion that console.* output is not masked. Masking is runner-wide after setSecret/add-mask, regardless of whether output comes from console or @actions/core; please avoid presenting this rule as a secret-masking boundary.

      preferCoreLogging: "Use {{replacement}} instead of console.{{method}}() — @actions/core logging masks secrets and integrates with the Actions annotation system. console.* output is not masked.",

Files reviewed: 8/8 changed files
Comments generated: 2
Review effort level: Medium

Copilot · 2026-07-18T09:27:57Z

+      CallExpression(node) {
+        const method = getConsoleMethod(node);
+        if (!method) return;
+
+        const replacement = CONSOLE_TO_CORE[method]!;


The unconditional core replacement is intentional by design per the maintainer's direction. shim.cjs (required at the top of every setup/js script) registers global.core in all Node.js contexts, so core.* is always in scope regardless of whether the script explicitly imports @actions/core. There is no plain-script context where this replacement would throw. For coreObj aliases — those were an intermediate workaround that has been cleaned up; the codebase now uses core.* everywhere directly via shim.cjs.

Copilot · 2026-07-18T09:27:49Z

+      description:
+        "Prefer @actions/core logging methods (core.info, core.error, core.warning, core.debug) over console.* — " +
+        "global.core is always available via shim.cjs in Node.js context and via github-script in Actions context. " +
+        "console.* bypasses GitHub Actions' built-in secret masking and structured annotation system; core logging ensures secrets in output are redacted and messages appear correctly in the Actions UI.",


Fixed in commit fix(eslint): correct misleading security claim. Removed the claim that core.info masks secrets — updated both the docs.description and the preferCoreLogging message to focus on the correct rationale: core.* integrates with the Actions annotation system (errors/warnings surface as file annotations) and produces structured log output, while global.core is always available via shim.cjs.

pelikhan · 2026-07-18T08:23:26Z

@copilot resolve the merge conflicts on this branch.

…ore-logging-677bf81819ff7157 # Conflicts: # actions/setup/js/generate_usage_activity_summary.cjs # actions/setup/js/merge_remote_agent_github_folder.cjs Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-18T08:38:26Z

@copilot resolve the merge conflicts on this branch.

Resolved in the merge commit dabafab. Two conflicts in generate_usage_activity_summary.cjs and merge_remote_agent_github_folder.cjs — kept the try/catch error handling added by main and the core.* logging from this branch.

…f7157

pelikhan · 2026-07-18T08:56:15Z

@copilot fix https://github.com/github/gh-aw/actions/runs/29638238036/job/88064220345?pr=46195

…instead of console.log Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-18T09:02:55Z

@copilot fix https://github.com/github/gh-aw/actions/runs/29638238036/job/88064220345?pr=46195

Fixed in commit fix(test): update generate_workflow_overview test. The test was still spying on console.log for the success message, but the production code was already migrated to core.info(...). Updated the assertion to check mockCore.info instead.

gh-aw-bot · 2026-07-18T09:20:15Z

@copilot please run the pr-finisher skill address the unresolved review feedback: copilot-pull-request-reviewer: #46195 (comment); copilot-pull-request-reviewer: #46195 (comment) and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 11.8 AIC · ⌖ 6.81 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

… rule docs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

pelikhan · 2026-07-18T11:14:18Z

@copilot fix https://github.com/github/gh-aw/actions/runs/29639196642/job/88067804477#step:4:1

Copilot · 2026-07-18T11:25:17Z

@copilot fix https://github.com/github/gh-aw/actions/runs/29639196642/job/88067804477#step:4:1

This is a stale CI cache issue, not a code bug. The CI job used a cached node_modules (Cache hit in the logs) from a prior run, which caused the spurious TypeScript error at add_labels.cjs(114,201). add_labels.cjs was not modified in this branch.

Locally, make build-js (which runs npm ci + npm run typecheck) and make test-impacted-js both pass cleanly with TypeScript 7.0.2. CI just needs to be re-triggered (close/reopen, workflow_dispatch, or a push) to get a fresh cache.

gh-aw-bot · 2026-07-18T11:39:16Z

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate failed checks (js-typecheck, impacted-js-tests), and rerun checks once the branch is ready.

Generated by 👨‍🍳 PR Sous Chef · 7.08 AIC · ⌖ 6.53 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

pelikhan · 2026-07-18T11:47:36Z

@copilot resolve the merge conflicts on this branch.

…etween setup/js and eslint-factory Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

…ore-logging-677bf81819ff7157 # Conflicts: # eslint-factory/eslint.config.cjs # eslint-factory/src/index.ts Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

… rule alongside prefer-core-logging Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-18T12:11:12Z

@copilot please run the pr-finisher skill, address unresolved review feedback, investigate failed checks (js-typecheck, impacted-js-tests), and rerun checks once the branch is ready.

...

Done. Here's what was addressed in this run:

CI failures fixed:

js-typecheck: passes locally — prior commits after the failing CI HEAD already fixed the add_labels.cjs TS error.
impacted-js-tests: fixed a Makefile bug in test-impacted-js where cd actions/setup/js left the shell in the wrong directory for the subsequent cd eslint-factory. This only manifests when both directories have changed simultaneously (commit fix(make): use absolute paths in test-impacted-js…). All 296 tests now pass locally.

Mergeable:

Branch was BEHIND main — merged origin/main, resolved conflicts in eslint-factory/eslint.config.cjs and eslint-factory/src/index.ts (kept both prefer-core-logging from this branch and no-core-error-then-process-exit from main).

Review threads:

Thread on security claim (outdated) — code was fixed in a prior commit (fix(eslint): correct misleading security claim), reply already posted.
Thread on hardcoded core alias — the unconditional approach is intentional per maintainer direction (shim.cjs always provides global.core), reply already posted. Could not resolve threads via API (403).

Local validation: make build-js ✅ · make lint ✅ · make test-unit ✅ · make test-impacted-js ✅

CI must be re-triggered by a maintainer (close/reopen or push) for the green CI signal before merge.

…ore-logging-677bf81819ff7157 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-07-18T12:24:16Z

@copilot resolve the merge conflicts on this branch.

Merged origin/main — clean merge, no conflicts (one new commit: 3a7b005 enabling Duplicate Code Detector detection). Branch is now up to date.

github-actions · 2026-07-20T18:08:08Z

🎉 This pull request is included in a new release.

Release: v0.82.14

github-actions Bot added automation cookie Issue Monster Loves Cookies! eslint labels Jul 17, 2026

Copilot started work on behalf of pelikhan July 17, 2026 11:29 View session

Copilot AI and others added 2 commits July 17, 2026 11:37

plan: address feedback to always favor core.* over console.*

978ed10

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 17, 2026 11:50

Copilot AI requested a review from pelikhan July 17, 2026 11:50

github-actions Bot added pr-action:batch_review pr-agent:automation pr-batch:linter-additions pr-priority:medium pr-risk:medium pr-type:feature labels Jul 18, 2026

pelikhan marked this pull request as ready for review July 18, 2026 05:30

Copilot AI review requested due to automatic review settings July 18, 2026 05:30

Copilot started reviewing on behalf of pelikhan July 18, 2026 05:30 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 18, 2026

[pr-sous-chef] Run report — 0 nudged, 0 skipped #46313

Closed

Copilot started work on behalf of pelikhan July 18, 2026 08:24 View session

Copilot finished work on behalf of pelikhan July 18, 2026 08:38

Merge branch 'main' into eslint-miner/prefer-core-logging-677bf81819f…

d2a8dea

…f7157

Copilot started work on behalf of pelikhan July 18, 2026 08:56 View session

fix(test): update generate_workflow_overview test to check core.info …

462a4f9

…instead of console.log Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 18, 2026 09:03

Copilot started work on behalf of gh-aw-bot July 18, 2026 09:21 View session

fix(eslint): correct misleading security claim in prefer-core-logging…

78cf96d

… rule docs Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 18, 2026 09:35

Copilot AI requested a review from gh-aw-bot July 18, 2026 09:35

Copilot started work on behalf of pelikhan July 18, 2026 11:15 View session

Copilot finished work on behalf of pelikhan July 18, 2026 11:25

Copilot started work on behalf of gh-aw-bot July 18, 2026 11:40 View session

Copilot AI and others added 3 commits July 18, 2026 11:59

fix(make): use absolute paths in test-impacted-js to avoid cd drift b…

0358483

…etween setup/js and eslint-factory Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into eslint-miner/prefer-c…

7e5ed35

…ore-logging-677bf81819ff7157 # Conflicts: # eslint-factory/eslint.config.cjs # eslint-factory/src/index.ts Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

merge: sync with origin/main; include no-core-error-then-process-exit…

ac5dd5a

… rule alongside prefer-core-logging Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 18, 2026 12:11

Copilot started work on behalf of pelikhan July 18, 2026 12:12 View session

Merge remote-tracking branch 'origin/main' into eslint-miner/prefer-c…

0487b3a

…ore-logging-677bf81819ff7157 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan July 18, 2026 12:24

pelikhan merged commit 4938772 into main Jul 18, 2026

pelikhan deleted the eslint-miner/prefer-core-logging-677bf81819ff7157 branch July 18, 2026 12:27

Uh oh!

Conversation

github-actions Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

New ESLint rule: prefer-core-logging

Migration: console.* → core.* in actions/setup/js

Other fixes

Motivation

Uh oh!

pelikhan commented Jul 17, 2026

Uh oh!

pelikhan commented Jul 17, 2026

Uh oh!

Copilot AI commented Jul 17, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

🤖 PR Triage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Copilot AI Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

pelikhan commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

gh-aw-bot commented Jul 18, 2026

Uh oh!

pelikhan commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

gh-aw-bot commented Jul 18, 2026

Uh oh!

pelikhan commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

Copilot AI commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 17, 2026 •

edited

Loading

New ESLint rule: `prefer-core-logging`

Migration: `console.` → `core.` in `actions/setup/js`