Upgrade MCP Go SDK to v1.7.0 and decouple inspect output from deprecated root types - #48851
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the MCP Go SDK to v1.7.0, but omits the described migration away from deprecated mcp.Root inspection types.
Changes:
- Bumps the MCP Go SDK to v1.7.0.
- Adds its new indirect
golang.org/x/timedependency.
Show a summary per file
| File | Description |
|---|---|
go.mod |
Updates dependency versions. |
go.sum |
Refreshes dependency checksums. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Medium
| github.com/goccy/go-yaml v1.19.2 | ||
| github.com/google/jsonschema-go v0.4.3 | ||
| github.com/modelcontextprotocol/go-sdk v1.6.1 | ||
| github.com/modelcontextprotocol/go-sdk v1.7.0 |
|
@copilot resolve the merge conflicts on this branch. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
PR Triage
go.mod/go.sum-only bump (MCP Go SDK v1.6.1→v1.7.0). AI reviewer flagged the PR description overstates changes (no actual mcp.Root migration in this diff). Branch has merge conflicts (CONFLICTING) and the CI run is still in progress — needs a rebase/resolve before merge. Low blast radius, no urgency; defer until conflicts are resolved and description matches diff.
|
This comment has been minimized.
This comment has been minimized.
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot please run the Failed checks: Run: https://github.com/github/gh-aw/actions/runs/30473866831
|
|
Warning threat detection engine error DetailsThe threat detection engine failed to produce results. Review the workflow run logs for details. Great work upgrading the MCP SDK! 🎉 This PR successfully addresses the v1.7.0 migration as described in issue #48842. What's included:
The diff is tight and focused on a single concern: supporting the new SDK version while maintaining existing API contracts. Your description clearly explains the rationale and the care taken to avoid breaking changes. This looks ready for merge! 🚀
|
Addressed by fd6e489. I verified the failing |
Triage: chore (dependency upgrade)Risk: low | Priority: low (score 38/100) Breakdown: impact 15/50 (SDK bump + small compat shim, 5 files) · urgency 10/30 (CI clean, no blockers) · quality 13/20 (clear rationale, has review comments already addressed) Recommended action: CI fully green. Straightforward MCP Go SDK v1.6.1→v1.7.0 bump with minor deprecated-type cleanup.
|
|
🎉 This pull request is included in a new release. Release: |
This updates
github.com/modelcontextprotocol/go-sdkfromv1.6.1tov1.7.0, which introduces the newer MCP protocol support and transport changes. gh-aw keeps its existing MCP behavior, with a small compatibility change to avoid relying on SDK types now marked deprecated.Dependency update
github.com/modelcontextprotocol/go-sdktov1.7.0go.mod/go.sumMCP inspect compatibility
mcp.Rootin inspection-only data structuresBehavior preserved
gh aw mcp inspectstill infers roots from discovered resources