Skip to content

Upgrade MCP Go SDK to v1.7.0 and decouple inspect output from deprecated root types - #48851

Merged
pelikhan merged 17 commits into
mainfrom
copilot/update-go-sdk-v170
Jul 29, 2026
Merged

Upgrade MCP Go SDK to v1.7.0 and decouple inspect output from deprecated root types#48851
pelikhan merged 17 commits into
mainfrom
copilot/update-go-sdk-v170

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This updates github.com/modelcontextprotocol/go-sdk from v1.6.1 to v1.7.0, which introduces the newer MCP protocol support and transport changes. gh-aw keeps its existing MCP behavior, with a small compatibility change to avoid relying on SDK types now marked deprecated.

  • Dependency update

    • Bump github.com/modelcontextprotocol/go-sdk to v1.7.0
    • Refresh go.mod / go.sum
  • MCP inspect compatibility

    • Replace use of deprecated mcp.Root in inspection-only data structures
    • Add a local root info type for inferred root display data
  • Behavior preserved

    • gh aw mcp inspect still infers roots from discovered resources
    • MCP tool/resource discovery continues to use the SDK directly where those types remain current
type MCPRootInfo struct {
	URI  string
	Name string
}

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 19.7 AIC · ⌖ 5.73 AIC · ⊞ 7.6K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 14.7 AIC · ⌖ 8.65 AIC · ⊞ 5.2K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10 AIC · ⌖ 6.62 AIC · ⊞ 7.8K ·
Comment /souschef to run again


Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.35 AIC · ⌖ 3.62 AIC · ⊞ 7.8K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update github.com/modelcontextprotocol/go-sdk to v1.7.0 Upgrade MCP Go SDK to v1.7.0 and decouple inspect output from deprecated root types Jul 29, 2026
Copilot AI requested a review from pelikhan July 29, 2026 11:50
@pelikhan
pelikhan marked this pull request as ready for review July 29, 2026 11:50
Copilot AI review requested due to automatic review settings July 29, 2026 11:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the MCP Go SDK to v1.7.0, but omits the described migration away from deprecated mcp.Root inspection types.

Changes:

  • Bumps the MCP Go SDK to v1.7.0.
  • Adds its new indirect golang.org/x/time dependency.
Show a summary per file
File Description
go.mod Updates dependency versions.
go.sum Refreshes dependency checksums.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/2 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread go.mod
github.com/goccy/go-yaml v1.19.2
github.com/google/jsonschema-go v0.4.3
github.com/modelcontextprotocol/go-sdk v1.6.1
github.com/modelcontextprotocol/go-sdk v1.7.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed on this branch in 076b4c5; this pass only refreshed the follow-up test expectations and wasm goldens in b40f28c.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts on this branch.

Copilot AI and others added 2 commits July 29, 2026 12:45
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts on this branch.

Resolved on this branch in 9c76654, with the follow-up MCP inspect compatibility fix in 076b4c5.

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

  • Category: chore (dependency bump)
  • Risk: low
  • Priority score: 38/100 (impact 15, urgency 8, quality 15)
  • Recommendation: defer

go.mod/go.sum-only bump (MCP Go SDK v1.6.1→v1.7.0). AI reviewer flagged the PR description overstates changes (no actual mcp.Root migration in this diff). Branch has merge conflicts (CONFLICTING) and the CI run is still in progress — needs a rebase/resolve before merge. Low blast radius, no urgency; defer until conflicts are resolved and description matches diff.

Generated by 🔧 PR Triage Agent · aut00 · 47.6 AIC · ⌖ 5.15 AIC · ⊞ 7.6K ·

@github-actions

This comment has been minimized.

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Copilot AI and others added 3 commits July 29, 2026 16:11
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Addressed in a4e786b.

@pelikhan

Copy link
Copy Markdown
Collaborator

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@pelikhan

Copy link
Copy Markdown
Collaborator

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address the remaining failed checks, and rerun CI once fixes are pushed.

Failed checks:

Run: https://github.com/github/gh-aw/actions/runs/30473866831

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 6.35 AIC · ⌖ 3.62 AIC · ⊞ 7.8K ·
Comment /souschef to run again

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

Copy link
Copy Markdown
Contributor

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Great work upgrading the MCP SDK! 🎉 This PR successfully addresses the v1.7.0 migration as described in issue #48842.

What's included:

  • ✅ Dependency update to github.com/modelcontextprotocol/go-sdk@v1.7.0
  • ✅ Compatibility fix for deprecated mcp.Root type in inspect output
  • ✅ Test coverage updated (wasm_golden_test.go)
  • ✅ Behavior preserved — MCP protocol negotiation continues to work as expected

The diff is tight and focused on a single concern: supporting the new SDK version while maintaining existing API contracts. Your description clearly explains the rationale and the care taken to avoid breaking changes. This looks ready for merge! 🚀

Generated by ✅ Contribution Check · aut00 · 45.5 AIC · ⊞ 8.7K ·

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address the remaining failed checks, and rerun CI once fixes are pushed.

Failed checks:...

Addressed by fd6e489. I verified the failing TestDailyAgentOfTheDayBlogWriterHasGitDenialMitigationAllowlist locally with go test ./pkg/workflow -run TestDailyAgentOfTheDayBlogWriterHasGitDenialMitigationAllowlist -count=1, and make test-unit BASE_REF=$(git merge-base HEAD origin/main) plus make test also pass on the current branch head. I can’t re-trigger CI from this agent, so the PR still needs a maintainer to rerun checks on the latest commit.

@pelikhan
pelikhan merged commit 50db787 into main Jul 29, 2026
30 checks passed
@pelikhan
pelikhan deleted the copilot/update-go-sdk-v170 branch July 29, 2026 18:35
@github-actions

Copy link
Copy Markdown
Contributor

Triage: chore (dependency upgrade)

Risk: low | Priority: low (score 38/100)

Breakdown: impact 15/50 (SDK bump + small compat shim, 5 files) · urgency 10/30 (CI clean, no blockers) · quality 13/20 (clear rationale, has review comments already addressed)

Recommended action: batch_review (group with other low-risk dependency/tooling PRs)

CI fully green. Straightforward MCP Go SDK v1.6.1→v1.7.0 bump with minor deprecated-type cleanup.

Generated by 🔧 PR Triage Agent · aut00 · 40.7 AIC · ⌖ 5.25 AIC · ⊞ 7.9K ·

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.84.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deps] Update github.com/modelcontextprotocol/go-sdk from v1.6.1 to v1.7.0

4 participants