CLI consistency: reject legacy nested `gh` fallback under multi-subcommand parents by Copilot · Pull Request #49673 · github/gh-aw

Copilot · 2026-08-01T22:30:11Z

Manual CLI review found that gh aw <parent> gh --help (secrets|mcp|project|pr|env) rendered parent help, creating a hidden/duplicate-command impression and inconsistent unknown-command behavior. This change makes those invocations fail explicitly as unknown commands.

Behavior fix: block legacy nested gh path
- Added a hidden gh guard subcommand that always returns an unknown-command error for the parent command path.
- Prevents Cobra help fallback from treating gh --help as parent help for these command groups.
Scope of application
- Wired the guard into:
  - secrets
  - mcp
  - project
  - pr
  - env
Regression coverage
- Added a focused consistency test asserting gh --help under each affected parent returns:
  - unknown command "gh" for "<parent>"

func newLegacyGHGuardSubcommand() *cobra.Command {
	return &cobra.Command{
		Use:                "gh",
		Hidden:             true,
		DisableFlagParsing: true,
		RunE: func(cmd *cobra.Command, _ []string) error {
			return fmt.Errorf("unknown command %q for %q", cmd.Name(), cmd.Parent().CommandPath())
		},
	}
}

Fixes [cli-consistency] CLI Consistency Issues - 2026-07-31 #49355

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.35 AIC · ⌖ 6.47 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

…arents Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Adds a hidden Cobra guard to reject legacy nested gh invocations consistently.

Changes:

Introduces a reusable hidden gh guard subcommand.
Applies it to five multi-subcommand parents.
Adds regression coverage for gh --help.

Show a summary per file

File	Description
`pkg/cli/gh_guard_subcommand.go`	Implements the rejection guard.
`pkg/cli/secrets_command.go`	Registers the guard for `secrets`.
`pkg/cli/mcp.go`	Registers the guard for `mcp`.
`pkg/cli/project_command.go`	Registers the guard for `project`.
`pkg/cli/pr_command.go`	Registers the guard for `pr`.
`pkg/cli/env_command.go`	Registers the guard for `env`.
`pkg/cli/cli_consistency_help_test.go`	Tests consistent rejection across affected parents.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 7/7 changed files
Comments generated: 0
Review effort level: Balanced

github-actions · 2026-08-01T23:14:50Z

⚠️ PR Code Quality Reviewer failed during code quality review.

github-actions · 2026-08-01T23:14:50Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

github-actions · 2026-08-01T23:14:54Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (53 additions found).

github-actions · 2026-08-01T23:15:10Z

✅ Test Quality Sentinel completed test quality analysis.

github-actions

Review: LGTM

The change is focused, correct, and well-tested.

DisableFlagParsing: true is the right mechanism — it ensures --help reaches RunE instead of being intercepted by Cobra's flag parser, which is exactly what blocks the silent parent-help fallback.
Error message format matches the test assertions exactly.
All 5 affected command groups are covered by the regression test.
No security or correctness concerns.

Minor nit (non-blocking): The RunE closure names the args parameter args []string but never uses it. Consider renaming to _ for clarity, e.g. func(cmd *cobra.Command, _ []string) error {.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 18.8 AIC · ⌖ 10.3 AIC · ⊞ 5.4K

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd — two minor suggestions, no blocking issues.

📋 Key Themes & Highlights

Key Themes

Coverage scope: experiments (2 subcommands) is the one remaining multi-subcommand parent that does not yet have the guard. Worth adding for consistency.
Test breadth: Tests confirm the ["gh", "--help"] path; ["gh", "subcommand"] with extra args is not exercised.

Positive Highlights

✅ Excellent single-responsibility abstraction: one tiny file, one reusable guard, wired uniformly into five commands.
✅ DisableFlagParsing: true is the right knob — prevents Cobra from consuming --help before the RunE fires.
✅ Regression test is table-driven, covers all affected commands, and reads as a clear specification.
✅ Zero deletions — purely additive, low risk.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 37.7 AIC · ⌖ 7.86 AIC · ⊞ 7.1K
_{Comment /matt to run again}

github-actions · 2026-08-01T23:20:30Z

+		Use:                "gh",
+		Hidden:             true,
+		DisableFlagParsing: true,
+		RunE: func(cmd *cobra.Command, args []string) error {


[/diagnosing-bugs] The args parameter is unused — name it _ per Go convention to signal it is intentionally discarded and avoid linter warnings.

💡 Suggested fix

RunE: func(cmd *cobra.Command, _ []string) error {

@copilot please address this.

Updated in dfef025ce8: RunE now uses _ []string to intentionally discard the unused args parameter.

github-actions · 2026-08-01T23:20:30Z

+
+			err := cmd.Execute()
+			require.Error(t, err)
+			assert.Equal(t, `unknown command "gh" for "`+tt.cmdName+`"`, err.Error())


[/tdd] The test only verifies the error message for the first positional arg (gh), not for deeper paths like gh subcommand --help. Consider adding a case to confirm that gh aw <parent> gh subcommand also returns an error, guarding against args being passed to the guard command.

💡 Example additional table row

{name: "secrets gh with args", newCmd: NewSecretsCommand, cmdName: "secrets", args: []string{"gh", "set", "--help"}},

With the current DisableFlagParsing: true this should still error; a test would lock in that guarantee.

@copilot please address this.

Addressed in dfef025ce8: added a nested-args regression case (gh set --help) in TestLegacyNestedGHHelpIsRejected to verify the guard still errors when extra positional args are present.

github-actions · 2026-08-01T23:20:36Z

🧪 Test Quality Sentinel Report

✅ Test Quality Score: 85/100 — Excellent

Analyzed 2 test(s): 2 design, 0 implementation, 0 violation(s).

📊 Metrics (2 tests)

Metric	Value
Analyzed	2 (Go: 2, JS: 0)
✅ Design	2 (100%)
⚠️ Implementation	0 (0%)
Edge/error coverage	1 (50%)
Duplicate clusters	0
Inflation	No (test:prod ≈ 1.1:1)
🚨 Violations	0

Test	File	Classification	Issues
`TestLegacyNestedGHHelpIsRejected`	`pkg/cli/cli_consistency_help_test.go`	design_test / behavioral_contract / high_value	None
`TestSubcommandListingsUseHyphenBullets` (extended)	`pkg/cli/cli_consistency_help_test.go`	design_test / behavioral_contract / high_value	None

Verdict

✅ passed. 0% implementation tests (threshold: 30%). Build tag present. No mock violations.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 34.3 AIC · ⌖ 9.89 AIC · ⊞ 8.4K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: 85/100. 0% implementation tests (threshold: 30%).

gh-aw-bot · 2026-08-01T23:50:08Z

@copilot
Please investigate this PR and move it toward merge readiness.
Failed checks:

impacted-go-tests: https://github.com/github/gh-aw/actions/runs/30721835547/job/91428348690
impacted-go-tests: https://github.com/github/gh-aw/actions/runs/30722461030/job/91429489478
agent: https://github.com/github/gh-aw/actions/runs/30722461036/job/91429596642
Unit tests (A-C): https://github.com/github/gh-aw/actions/runs/30721835547/job/91428579417
Unit tests (A-C): https://github.com/github/gh-aw/actions/runs/30722461030/job/91429615736
Refresh the branch if needed, address unresolved review feedback, and run the pr-finisher skill.
Run details: https://github.com/github/gh-aw/actions/runs/30723841495

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.35 AIC · ⌖ 6.47 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-02T00:06:28Z

@copilot
Please investigate this PR and move it toward merge readiness.
Failed checks:...

Implemented fixes in commit dfef025ce8: addressed the unresolved review feedback (_ for unused guard args and added nested gh-with-args coverage), synced the aw-failure-investigator prefetch expectation with current workflow behavior, and ran local validation (make fmt, make lint, make test-unit, make test).

github-actions · 2026-08-02T07:12:34Z

🔍 Triage Summary

Field	Value
Category	`bug`
Risk	`medium`
Priority	`medium`
Score	58/100 (impact 25 + urgency 15 + quality 18)
Recommended action	`fast_track`
Batch	—

CLI fix rejecting legacy nested gh fallback for multi-subcommand parents. CI green, approved by automated reviewer.

Automated triage — see the triage report for full context.

Generated by 🔧 PR Triage Agent · auto · 40.3 AIC · ⌖ 4.01 AIC · ⊞ 8K · ◷

Initial plan

fc7a5e8

Copilot AI assigned Copilot and pelikhan Aug 1, 2026

Copilot started work on behalf of pelikhan August 1, 2026 22:30 View session

Copilot AI linked an issue Aug 1, 2026 that may be closed by this pull request

[cli-consistency] CLI Consistency Issues - 2026-07-31 #49355

Closed

fix(cli): reject legacy nested gh help fallback on multi-subcommand p…

d34d39d

…arents Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix CLI consistency issues for threat detection~~ CLI consistency: reject legacy nested gh fallback under multi-subcommand parents Aug 1, 2026

Copilot AI requested a review from pelikhan August 1, 2026 22:47

Copilot finished work on behalf of pelikhan August 1, 2026 22:47

pelikhan marked this pull request as ready for review August 1, 2026 23:00

Copilot AI review requested due to automatic review settings August 1, 2026 23:00

Copilot started reviewing on behalf of pelikhan August 1, 2026 23:00 View session

Copilot AI reviewed Aug 1, 2026

View reviewed changes

github-actions Bot approved these changes Aug 1, 2026

View reviewed changes

github-actions Bot reviewed Aug 1, 2026

View reviewed changes

github-actions Bot approved these changes Aug 1, 2026

View reviewed changes

Merge branch 'main' into copilot/cli-consistency-issues-2026-07-31

a8ffac0

github-actions Bot mentioned this pull request Aug 1, 2026

[pr-sous-chef] PR Sous Chef run report — 2026-08-01 00:15Z #49427

Closed

Copilot started work on behalf of gh-aw-bot August 1, 2026 23:50 View session

fix(cli): address review feedback and sync failure-investigator test

dfef025

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI requested a review from gh-aw-bot August 2, 2026 00:08

Copilot finished work on behalf of gh-aw-bot August 2, 2026 00:08

github-actions Bot mentioned this pull request Aug 2, 2026

[pr-sous-chef] PR Sous Chef run report #49683

Open

github-actions Bot added pr-action:fast_track pr-agent:github-copilot pr-priority:medium pr-risk:medium pr-type:bug labels Aug 2, 2026

pelikhan merged commit 1d9b0f8 into main Aug 2, 2026
29 checks passed

pelikhan deleted the copilot/cli-consistency-issues-2026-07-31 branch August 2, 2026 09:38

Uh oh!

Conversation

Copilot AI commented Aug 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Review: LGTM

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 1, 2026

🧪 Test Quality Sentinel Report

Verdict

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gh-aw-bot commented Aug 1, 2026

Uh oh!

Copilot AI commented Aug 2, 2026

Uh oh!

github-actions Bot commented Aug 2, 2026

🔍 Triage Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 1, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Aug 1, 2026 •

edited

Loading

github-actions Bot commented Aug 1, 2026 •

edited

Loading

github-actions Bot commented Aug 1, 2026 •

edited

Loading

github-actions Bot commented Aug 1, 2026 •

edited

Loading