fix: replace strings.Index == 0 with strings.HasPrefix; enforce stringsindexhasprefix linter

[Copilot]

The stringsindexhasprefix analyzer had one remaining production violation — strings.Index(s, sub) == 0 in frontmatter_on_section_cleanup.go, which is less readable than strings.HasPrefix and leaves an unused idx binding.

Changes

• pkg/workflow/frontmatter_on_section_cleanup.go: Replace the flagged pattern with strings.HasPrefix, dropping the now-unnecessary idx variable:

  // before
  if idx := strings.Index(trimmedLine, "workflow_run:"); idx == 0 {
  // after
  if strings.HasPrefix(trimmedLine, "workflow_run:") {

• .github/workflows/cgo.yml: Add -stringsindexhasprefix to both the default and wasm LINTER_FLAGS gates, enforcing the rule in CI now that no production violations remain.

• Fixes stringsindexhasprefix: real production violation in frontmatter_on_section_cleanup.go — strings.Index(...) == 0 should be string [Content truncated due to length] #49267

---

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.35 AIC · ⌖ 6.47 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

[Copilot]

🟢 Ready to approve

The behavior-preserving rewrite is correct, tested by existing cases, and consistently enforced across CI targets.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

Replaces a redundant strings.Index prefix check and enforces the corresponding custom analyzer in CI.

Changes:

• Use strings.HasPrefix for clearer prefix detection.
• Enable stringsindexhasprefix for native and wasm lint gates.

File summaries

File	Description
pkg/workflow/frontmatter_on_section_cleanup.go	Simplifies workflow_run: detection.
.github/workflows/cgo.yml	Enforces the analyzer in both custom-linter jobs.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

[gh-aw-bot]

@copilot
Please investigate this PR and move it toward merge readiness.
Failed checks:

• Unit tests (A-C): https://github.com/github/gh-aw/actions/runs/30722797904/job/91429505130
• Refresh the branch if needed, address unresolved review feedback, and run the pr-finisher skill.
• Run details: https://github.com/github/gh-aw/actions/runs/30723841495

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 9.35 AIC · ⌖ 6.47 AIC · ⊞ 8.1K · ◷
_{Comment /souschef to run again}

[Copilot]

@copilot
Please investigate this PR and move it toward merge readiness.
Failed checks:...

Addressed in 7a27f50.

I investigated the failed Unit tests (A-C) run and fixed the failure by updating pkg/cli/aw_failure_investigator_workflow_test.go to match current workflow behavior (FAILURE_CONCLUSIONS no longer includes cancelled).

Validation run locally:

• make fmt
• make lint
• make test-unit
• make test
• make recompile
• make agent-report-progress
• parallel_validation (CodeQL skipped as trivial test-only change)

No unresolved in-scope review threads were present. The branch is not behind main.

[github-actions]

🔍 Triage Summary

Field	Value
Category	refactor
Risk	low
Priority	medium
Score	35/100 (impact 10 + urgency 10 + quality 15)
Recommended action	defer
Batch	—

Tiny lint-compliance fix (strings.HasPrefix), reviewer approved but no CI run recorded — verify CI before merge.

Automated triage — see the triage report for full context.

Generated by 🔧 PR Triage Agent · auto · 40.3 AIC · ⌖ 4.01 AIC · ⊞ 8K · ◷