Skip to content

fix(security): disable semgrep/semgrep container — Critical/High CVEs, no upstream fix available - #49694

Merged
pelikhan merged 3 commits into
mainfrom
copilot/container-image-scan-remediation-again
Aug 2, 2026
Merged

fix(security): disable semgrep/semgrep container — Critical/High CVEs, no upstream fix available#49694
pelikhan merged 3 commits into
mainfrom
copilot/container-image-scan-remediation-again

Conversation

Copilot AI commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

semgrep/semgrep:latest (sha256:bdf7013...) carries 8 Critical and 32 High CVEs (curl, python3, sqlite-libs, git system packages; mcp@1.23.3, wheel@0.45.1 Python packages; Go stdlib go1.25.10). Confirmed semgrep/semgrep:1.172.0 (newest available) ships identical vulnerable package versions — no patched image exists upstream.

Changes

  • shared/mcp/semgrep.md — Remove mcp-servers container block; replace with security comment (mirrors the brave.md pattern used for mcp/brave-search in [container-image-scan] Container findings for docker.io/mcp/brave-search #48546)
  • daily-semgrep-scan.md — Drop schedule: daily trigger; keep workflow_dispatch for manual re-activation; add comment referencing this issue
  • actions-lock.json — Remove semgrep/semgrep:latest pinned digest entry

Re-enabling

When semgrep ships a patched image:

  1. Restore the mcp-servers block in shared/mcp/semgrep.md
  2. Update the digest in actions-lock.json
  3. Restore schedule: daily in daily-semgrep-scan.md
  4. Run make recompile

Copilot AI and others added 2 commits August 2, 2026 03:27
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Remove mcp-servers block from shared/mcp/semgrep.md following the
  brave.md pattern for containers with unpatched upstream CVEs
- Disable daily schedule in daily-semgrep-scan.md until a patched
  semgrep image is published upstream
- Remove semgrep/semgrep:latest pin from actions-lock.json
- Recompile all affected workflow lock files

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update semgrep/semgrep image to address vulnerabilities fix(security): disable semgrep/semgrep container — Critical/High CVEs, no upstream fix available Aug 2, 2026
Copilot AI requested a review from pelikhan August 2, 2026 03:36
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for addressing this critical security issue! The semgrep vulnerability remediation looks solid. Here are a few things to finalize:

  • Mark ready for review — This PR is currently a draft. Once you have confirmed the re-enablement plan with maintainers, mark it as ready.
  • Verify rebuild — Per the body, make recompile needs to be run after changes to compiled lock files. Confirm this step is completed.
  • Cross-check lock files — The changes span both actions-lock.json and the pkg/ pin files; ensure all references to semgrep/semgrep:latest are consistently removed.

The changes follow the precedent set in #48546 for the brave-search container (security comment + removal from locks). This looks like a solid security-first decision given the upstream situation. Ready to proceed once draft status is cleared! 🎯

Generated by ✅ Contribution Check · auto · 46.6 AIC · ⌖ 8.19 AIC · ⊞ 8.7K ·

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

🔍 Triage Summary

Field Value
Category bug
Risk medium
Priority high
Score 65/100 (impact 35 + urgency 25 + quality 5)
Recommended action fast_track
Batch container-security

Security fix disabling vulnerable semgrep container (Critical/High CVEs). Draft, no CI yet — undraft and get CI green before merge.

Automated triage — see the triage report for full context.

Generated by 🔧 PR Triage Agent · auto · 40.3 AIC · ⌖ 4.01 AIC · ⊞ 8K ·

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

PR Triage

  • Category:
  • Risk:
  • Priority: (score: 79/100)
    • Impact: 42/50, Urgency: 28/30, Quality: 9/20
  • Recommended action:
  • Batch:

Automated triage — see full report issue for details.

Structured data:

{
  "action": "fast_track",
  "category": "bug",
  "pr_number": 49694,
  "risk": "low"
}

Generated by 🔧 PR Triage Agent · auto · 73.4 AIC · ⌖ 3.47 AIC · ⊞ 8K ·

@pelikhan
pelikhan marked this pull request as ready for review August 2, 2026 13:55
Copilot AI review requested due to automatic review settings August 2, 2026 13:55
@pelikhan
pelikhan merged commit eae6ab4 into main Aug 2, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/container-image-scan-remediation-again branch August 2, 2026 13:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the vulnerable Semgrep container and automatic scan schedule pending an upstream fix.

Changes:

  • Removes Semgrep MCP configuration and image pins.
  • Disables scheduled Semgrep scans while retaining manual dispatch.
  • Regenerates workflow lock files, including an unrelated timeout change.
Show a summary per file
File Description
pkg/workflow/data/action_pins.json Removes the embedded Semgrep image pin.
pkg/actionpins/data/action_pins.json Removes the actionpins Semgrep fallback.
.github/aw/actions-lock.json Removes the repository Semgrep digest.
.github/workflows/shared/mcp/semgrep.md Disables the Semgrep MCP server.
.github/workflows/daily-semgrep-scan.md Removes the daily schedule.
.github/workflows/daily-semgrep-scan.lock.yml Regenerates the disabled scan workflow.
.github/workflows/smoke-checkout-pr-dispatch.lock.yml Unrelatedly doubles execution timeouts.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

# --allow-tool shell(yq)
# --allow-tool write
timeout-minutes: 10
timeout-minutes: 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[container-image-scan] Container findings for semgrep/semgrep:latest

3 participants