ci: enforce goroutinemissingrecover and trimleftright in lint gate - #49783
Merged
Conversation
5 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add goroutinemissingrecover analyzer to CI gate
ci: enforce goroutinemissingrecover and trimleftright in lint gate
Aug 2, 2026
Contributor
|
Great work! 🎯 This PR looks ready to go. You've cleanly promoted two custom analyzers (
|
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes two custom Go analyzers into the CI lint gate.
Changes:
- Enforces
goroutinemissingrecoverandtrimleftright. - Applies both analyzers to default and WebAssembly lint jobs.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds both analyzer flags to CI lint commands. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| # Note: -test=false intentionally scopes this gate to production code only. | ||
| - name: Run custom linters | ||
| run: make golint-custom LINTER_FLAGS="-errstringmatch -panicinlibrarycode -manualmutexunlock -osexitinlibrary -rawloginlib -logfatallibrary -regexpcompileinfunction -fprintlnsprintf -strconvparseignorederror -jsonmarshalignoredeerror -uncheckedtypeassertion -fmterrorfnoverbs -tolowerequalfold -httpnoctx -timeafterleak -errortypeassertion -execcommandwithoutcontext -sprintfint -stringsindexcontains -stringscountcontains -bytesbufferstring -ioutildeprecated -mapclearloop -mapdeletecheck -sprintfbool -appendoneelement -timenowsub -stringsjoinone -writebytestring -lenstringsplit -stringreplaceminusone -osgetenvlibrary -ossetenvlibrary -stringsindexhasprefix -contextcancelnotdeferred -wgdonenotdeferred -test=false" | ||
| run: make golint-custom LINTER_FLAGS="-errstringmatch -panicinlibrarycode -manualmutexunlock -osexitinlibrary -rawloginlib -logfatallibrary -regexpcompileinfunction -fprintlnsprintf -strconvparseignorederror -jsonmarshalignoredeerror -uncheckedtypeassertion -fmterrorfnoverbs -tolowerequalfold -httpnoctx -timeafterleak -errortypeassertion -execcommandwithoutcontext -sprintfint -stringsindexcontains -stringscountcontains -bytesbufferstring -ioutildeprecated -mapclearloop -mapdeletecheck -sprintfbool -appendoneelement -timenowsub -stringsjoinone -writebytestring -lenstringsplit -stringreplaceminusone -osgetenvlibrary -ossetenvlibrary -stringsindexhasprefix -contextcancelnotdeferred -wgdonenotdeferred -goroutinemissingrecover -trimleftright -test=false" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two custom analyzers verified clean against the full codebase are promoted from non-enforced to CI-gated.
Changes
.github/workflows/cgo.yml: Added-goroutinemissingrecoverand-trimleftrighttoLINTER_FLAGSin both the default-build gate and theGOOS=js GOARCH=wasmgate, following the same pattern as the previous enforce-readiness batch (appendoneelement,timenowsub,stringsjoinone).Analyzers
goroutinemissingrecover— flagsgo func() { ... }()bodies missing a top-leveldefer+recover()guard; uses type-resolved builtin detection to avoid false positives from shadowedrecoveridentifiers.trimleftright— flagsstrings.TrimLeft/TrimRightcalls with multi-character literal cutsets that look like accidentalTrimPrefix/TrimSuffixmisuse; single-rune and whitespace/separator character-class cutsets are correctly exempted.Zero violations found across all enforced packages (
./cmd/... ./pkg/...and the wasm subset).