[WIP] Fix failing GitHub Actions job 'agent' - #49898
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Thanks for working on fixing the failing 'agent' job! 👋 Here are a few things to help this PR get ready:
If you need a hand validating the workflow or adding test coverage, you can assign this prompt to your agent:
|
Triage ResultCategory: bug | Risk: low | Score: 34/100 (impact 15, urgency 10, quality 9) Recommended action: defer WIP draft PR titled "[WIP] Fix failing GitHub Actions job agent", CI pending, small diff (2 files). Marked WIP — not ready for review; revisit once author removes WIP status.
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR updates the docs “noob tester” workflow to correctly install dependencies and start the documentation dev server from the docs/ directory, with logging and PID files stored under /tmp/gh-aw/agent.
Changes:
- Added a dedicated step to run
npm ciindocs/before starting the server. - Updated the server start command to run
npm run devfromdocs/, withnohupand explicit log/PID handling.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/docs-noob-tester.md | Adds docs dependency install and fixes docs server start directory + log/PID setup. |
| .github/workflows/docs-noob-tester.lock.yml | Regenerates the locked workflow to reflect the new install/start steps. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
| - name: Install docs dependencies | ||
| env: | ||
| EXPR_GITHUB_WORKSPACE: ${{ github.workspace }} | ||
| run: | | ||
| cd "$EXPR_GITHUB_WORKSPACE/docs" || exit 1 | ||
| npm ci |
| env: | ||
| EXPR_GITHUB_WORKSPACE: ${{ github.workspace }} | ||
| run: | | ||
| cd "$EXPR_GITHUB_WORKSPACE" || exit 1 > /tmp/gh-aw/agent/preview.log 2>&1 & | ||
| mkdir -p /tmp/gh-aw/agent | ||
| cd "$EXPR_GITHUB_WORKSPACE/docs" || exit 1 | ||
| nohup npm run dev -- --host 0.0.0.0 --port 4321 > /tmp/gh-aw/agent/preview.log 2>&1 & |
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.