-
Notifications
You must be signed in to change notification settings - Fork 117
Fixed the Validation for bbs-shared-home and archive-path #1327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
AakashSuresh2003
wants to merge
6
commits into
github:main
from
AakashSuresh2003:Fix-1211-Validate-bbs-shared-home-and-archive-path
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4e6a04b
Fixed the Validation for bbs-shared-home and archive-path
AakashSuresh2003 ad1004a
Update[1327]: Fixed the Validation for bbs-shared-home and archive-path
AakashSuresh2003 110c30a
Update[1327]: Fixed the Validation for bbs-shared-home and archive-path
AakashSuresh2003 be2b9da
Update[1327]: Modified the code due to dotnet formate failure
AakashSuresh2003 d302f8b
Fix[1211] Refine validation and wrote test case for BbsSharedHome, Ar…
AakashSuresh2003 58bf290
Fix[1211] Refined the codebase and updated the testcases
AakashSuresh2003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -51,7 +51,6 @@ public async Task Handle(MigrateRepoCommandArgs args) | |||||||
} | ||||||||
|
||||||||
ValidateOptions(args); | ||||||||
|
||||||||
var exportId = 0L; | ||||||||
var migrationSourceId = ""; | ||||||||
|
||||||||
|
@@ -384,5 +383,25 @@ private void ValidateUploadOptions(MigrateRepoCommandArgs args) | |||||||
throw new OctoshiftCliException("Either --aws-region or AWS_REGION environment variable must be set."); | ||||||||
} | ||||||||
} | ||||||||
// Validate BbsSharedHome | ||||||||
if (!string.IsNullOrEmpty(args.BbsSharedHome)) | ||||||||
{ | ||||||||
if (args.ShouldUploadArchive() && args.ArchivePath.IsNullOrWhiteSpace()) | ||||||||
{ | ||||||||
if (args.BbsSharedHome.HasValue() && !_fileSystemProvider.DirectoryExists(args.BbsSharedHome)) | ||||||||
{ | ||||||||
throw new OctoshiftCliException($"Invalid --bbs-shared-home path: '{args.BbsSharedHome}'. Directory does not exist."); | ||||||||
} | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
// Validate ArchivePath | ||||||||
if (!string.IsNullOrEmpty(args.ArchivePath)) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit
Suggested change
|
||||||||
{ | ||||||||
if (!_fileSystemProvider.FileExists(args.ArchivePath)) | ||||||||
{ | ||||||||
throw new OctoshiftCliException($"Invalid --archive-path: '{args.ArchivePath}'. File does not exist."); | ||||||||
} | ||||||||
} | ||||||||
|
||||||||
} | ||||||||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're already in
ValidateUploadOptions
there is not need to check forShouldUploadArchive
: