Guard GraphQL PR number conversion against int32 overflow#56
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-stack/sessions/dbb2b50f-34fb-4957-ac08-e19c1f96ba41 Co-authored-by: skarim <1701557+skarim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert #3
Guard GraphQL PR number conversion against int32 overflow
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a CodeQL-reported unsafe integer downcast by validating int PR numbers before converting them into graphql.Int (int32-backed) for GraphQL query variables.
Changes:
- Added
toGraphQLInt(n int) (graphql.Int, error)to enforce GraphQLIntrange bounds before conversion. - Updated
FindPRByNumberto use the validated conversion instead of a direct cast. - Added unit tests covering in-range success and out-of-range failure for the new helper.
Show a summary per file
| File | Description |
|---|---|
| internal/github/github.go | Adds the guarded int→graphql.Int conversion helper and uses it in FindPRByNumber. |
| internal/github/github_test.go | Adds unit tests for toGraphQLInt range validation behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
skarim
approved these changes
Apr 23, 2026
ryanclark
added a commit
to ryanclark/gh-stack
that referenced
this pull request
Jun 19, 2026
Ports the still-applicable upstream changes since the fork point, adapted to this fork's standard-GitHub-API architecture (no private stack backend; stack deps tracked via "Requires #N"). Each change was test-driven. Bug fixes: - github#56 guard GraphQL PR-number conversion against int32 overflow - github#41 skip merged+deleted branches when rebasing (rev-parse error) - github#42 same fix on the sync path - github#43 --onto rebase for merged branches: backfill refs, pre-seed onto state, stale-base fallback via merge-base - github#39 always anchor branch diffs on the merge-base (inflated diff counts) - github#95 sync now cascades when the stack is stale even if trunk is current; rebase skips queued branches (IsSkipped) - github#80 view --json resolves directly with typed exit codes (no prompt) - github#49 (Part A) ignore stale merged/closed PRs for reused branch names (the backend ListStacks path is intentionally omitted) Features (standard API only): - github#108 trunk command - github#51 switch command - github#74 unstack -> active - github#101 add adopts existing branch - github#40 fast-forward branches behind their remote - github#76 draft PRs by default + --open (adds MarkPRReadyForReview) - github#77 seed PR body from repo template (keeps "Requires #N") - github#94 sync --prune merged branches Infra / cleanup: - github#103/github#110 bump github.com/cli/cli/v2 to v2.93.0 (go get + tidy) - github#89 remove placeholder `merge` command + docs - fix stale `unstack [branch]` docs Note: this commit is layered on in-progress local work (go-git ops, PR/commit caching, discover command) that shares the same files, so the two are committed together. Full suite green: build, vet, go test ./...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the CodeQL alert on unsafe integer downcast when passing PR numbers into GraphQL query variables. The change ensures
intvalues are validated before converting tographql.Int(int32-backed).What changed
internal/github/github.go:toGraphQLInt(n int) (graphql.Int, error)math.MinInt32 <= n <= math.MaxInt32FindPRByNumberto use the validated conversion instead of direct cast.Behavioral impact
Focused coverage
internal/github/github_test.gofor:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/tmp/go-build2513184261/b287/cmd.test /tmp/go-build2513184261/b287/cmd.test -test.testlogfile=/tmp/go-build2513184261/b287/testlog.txt -test.paniconexit0 -test.timeout=10m0s conf�� g_.a 0.1-go1.25.7.lin--64 ux-amd64/pkg/tool/linux_amd64/compile user.name(http block)If you need me to access, download, or install something from one of these locations, you can either: