simplify unstack to only target the active stack#74
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies gh stack unstack by removing the optional [branch] positional argument so the command always targets the active stack (the stack containing the currently checked-out branch), and updates user-facing documentation accordingly.
Changes:
- Removed the
[branch]positional argument fromgh stack unstackand made the command always resolve via the current branch. - Updated CLI documentation (README, docs site reference, skill docs) to reflect the new invocation and behavior.
- Updated tests by removing branch-targeting coverage and adjusting the “correct stack removed” test to rely on current-branch resolution.
Show a summary per file
| File | Description |
|---|---|
| skills/gh-stack/SKILL.md | Updates unstack docs to remove [branch] and clarify it targets the active stack. |
| README.md | Updates unstack docs/examples to remove [branch] and describe active-stack targeting. |
| docs/src/content/docs/reference/cli.md | Updates reference docs for unstack usage and behavior without [branch]. |
| cmd/unstack.go | Removes positional arg handling and enforces no-args invocation. |
| cmd/unstack_test.go | Removes tests for branch-targeting and updates remaining tests for current-branch behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 2
0e36849 to
82ec1b3
Compare
Lukeghenco
approved these changes
May 8, 2026
ktravers
approved these changes
May 8, 2026
ryanclark
added a commit
to ryanclark/gh-stack
that referenced
this pull request
Jun 19, 2026
Ports the still-applicable upstream changes since the fork point, adapted to this fork's standard-GitHub-API architecture (no private stack backend; stack deps tracked via "Requires #N"). Each change was test-driven. Bug fixes: - github#56 guard GraphQL PR-number conversion against int32 overflow - github#41 skip merged+deleted branches when rebasing (rev-parse error) - github#42 same fix on the sync path - github#43 --onto rebase for merged branches: backfill refs, pre-seed onto state, stale-base fallback via merge-base - github#39 always anchor branch diffs on the merge-base (inflated diff counts) - github#95 sync now cascades when the stack is stale even if trunk is current; rebase skips queued branches (IsSkipped) - github#80 view --json resolves directly with typed exit codes (no prompt) - github#49 (Part A) ignore stale merged/closed PRs for reused branch names (the backend ListStacks path is intentionally omitted) Features (standard API only): - github#108 trunk command - github#51 switch command - github#74 unstack -> active - github#101 add adopts existing branch - github#40 fast-forward branches behind their remote - github#76 draft PRs by default + --open (adds MarkPRReadyForReview) - github#77 seed PR body from repo template (keeps "Requires #N") - github#94 sync --prune merged branches Infra / cleanup: - github#103/github#110 bump github.com/cli/cli/v2 to v2.93.0 (go get + tidy) - github#89 remove placeholder `merge` command + docs - fix stale `unstack [branch]` docs Note: this commit is layered on in-progress local work (go-git ops, PR/commit caching, discover command) that shares the same files, so the two are committed together. Full suite green: build, vet, go test ./...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unstackcommand previously accepted an optional [branch] positional argument to identify which stack to target. This was confusing because it wasn't clear that a branch name identifies a stack. This PR removes that argument so the command always targets the active stack — the one containing the currently checked-out branch.Motivation