Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert in to Urdu language #3223

Closed
wants to merge 16 commits into from
Closed

Convert in to Urdu language #3223

wants to merge 16 commits into from

Conversation

Areebey
Copy link

@Areebey Areebey commented May 14, 2024

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


@Areebey Areebey requested a review from a team as a code owner May 14, 2024 05:40
Merged the contribution
@jmeridth
Copy link
Member

@Areebey Thank you for your contribution but it looks like you have a good number of errors to work through via the GitHub Actions CI/tests status check.

@Izaquel2024

This comment was marked as spam.

@ahpook
Copy link
Contributor

ahpook commented Jun 15, 2024

@Areebey in order for this translation to work, you will need to add a YAML file as
_data/locales/ur.yml that follows the correct format - see https://github.com/github/opensource.guide/blob/main/_data/locales/en.yml for the example.

This will fix a lot of the test failures but there are many additional problems in the translation that must be fixed before this can merge. From the output of the test failures, I see some small changes that will fix most of the failures:

  • any time there is an internal link in markdown to another page, like building-community.md:29 :
[A friendly README](../starting-a-project/#writing-a-readme)

The anchor after the # needs to link to the translated name of that header

  • There are many links which have got Unicode characters embedded in them, maybe due to your editor? It looks like it has changed the ASCII . to a Unicode &#1748 entity ۔ These need to be fixed for the links to work, example building-community.md:179
(https://github.com/rub inius/rubinius/blob/HEAD/.github/contributing۔ md):

Thank you for this work, I hope you will keep improving it so we can add this language!

@Bulls888

This comment has been minimized.

@Bulls888

This comment has been minimized.

@ahpook ahpook marked this pull request as draft June 17, 2024 17:39
Wortason

This comment was marked as spam.

vlent3739

This comment was marked as spam.

@nickloo8888

This comment was marked as spam.

@nickloo8888

This comment was marked as spam.

@nickloo8888

This comment was marked as spam.

@HAERUL29

This comment was marked as spam.

@HAERUL29

This comment was marked as spam.

@nickloo8888

This comment was marked as spam.

@ahpook
Copy link
Contributor

ahpook commented Jul 12, 2024

@Areebey This is getting a lot of spam. I am going to lock conversation on this PR but will keep watching it for updates - if you push more commits I will re-open and hope we can get it merged. Thank you!

@github github locked as spam and limited conversation to collaborators Jul 12, 2024
@jmeridth
Copy link
Member

jmeridth commented Sep 5, 2024

@Areebey Are you able to address the failing tests?

@jmeridth
Copy link
Member

@Areebey going to close this. Please reopen and update if you would like to.

@jmeridth jmeridth closed this Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants