Fix duplicate step numbering in specify command#3647
Draft
BenBtg wants to merge 2 commits into
Draft
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e20ed25-f49e-41a6-b3d9-ac8f32e4ad17
Contributor
There was a problem hiding this comment.
Pull request overview
Renumbers the Specify command’s execution flow sequentially and adds regression coverage.
Changes:
- Renumbers specification writing and validation as steps 7 and 8.
- Adds tests for duplicate and non-sequential ordinals.
Show a summary per file
| File | Description |
|---|---|
templates/commands/specify.md |
Corrects duplicated step numbering. |
tests/test_specify_template_numbering.py |
Adds numbering regression tests. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Medium
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e20ed25-f49e-41a6-b3d9-ac8f32e4ad17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Specify command's main execution flow reused step 6, leaving the specification-writing and quality-validation phases structurally misnumbered. This renumbers the flow sequentially through step 8 and adds regression coverage that rejects duplicate, missing, or non-sequential top-level ordinals.
Preset overrides are unchanged because they do not embed the affected core execution flow.
Testing
uv run specify --helpuv sync && uv run pytestTargeted test:
.venv/bin/python -m pytest tests/test_specify_template_numbering.py -q(2 passed).AI Disclosure
GitHub Copilot (GPT-5.6 Sol) autonomously investigated the issue, implemented the template and regression-test changes, and prepared this pull request on behalf of @BenBtg.
Fixes: #2407