Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop allowing running MRVA with query outside of workspace #3302

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Stop allowing running MRVA with query outside of workspace #3302

merged 5 commits into from
Feb 5, 2024

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Jan 31, 2024

We currently allow users to run a MRVA with a query that is not in their workspace. However, this can become problematic, specially when adding multi-query support.

In this change we introduce a restriction where users cannot run a MRVA if the query is not in their workspace.

Checklist

TODO:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners January 31, 2024 14:49
robertbrignull
robertbrignull approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we have agreement that we want this behaviour change

extensions/ql-vscode/test/unit-tests/common/files.test.ts Show resolved Hide resolved
extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
@charisk charisk merged commit bc4d742 into main Feb 5, 2024
15 checks passed
@charisk charisk deleted the charisk/remove-single-query-special-case branch February 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @robertbrignull