Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable type models for Python in the model editor #3654

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

koesie10
Copy link
Member

@koesie10 koesie10 commented Jul 3, 2024

This enables type models for Python in the model editor. There is no query for generating type models or for complex access path suggestions, so a simple text box will be shown to enter the path and related type.

@koesie10 koesie10 marked this pull request as ready for review July 3, 2024 08:33
@koesie10 koesie10 requested a review from a team as a code owner July 3, 2024 08:33
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried running this and it worked fine for me. I'm not very familiar with the code but nothing looks wrong to me.

LGTM unless you want to get someone from the python team to try it out as well

Base automatically changed from koesie10/python-use-simplified-paths-and-endpoint-kinds to main July 4, 2024 07:35
@koesie10 koesie10 merged commit 01403ae into main Jul 4, 2024
23 checks passed
@koesie10 koesie10 deleted the koesie10/python-type-models branch July 4, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants