Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload ESLint results to code scanning #3709

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

aeisenberg
Copy link
Contributor

Minor change to CI to ensure our SARIF is uploaded to code scanning.

@aeisenberg aeisenberg requested a review from a team as a code owner September 12, 2024 02:46
@aeisenberg
Copy link
Contributor Author

Did I mess something up? Why did only 3 jobs run?

Regardless, I want to make sure alerts and fixes are appearing correctly before I merge this.

@aeisenberg aeisenberg force-pushed the aeisenberg/eslint-sarif branch 3 times, most recently from 50ddee9 to 4ca0e15 Compare September 12, 2024 22:24
@aeisenberg aeisenberg closed this Sep 15, 2024
@aeisenberg aeisenberg reopened this Sep 15, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@aeisenberg aeisenberg requested a review from a team as a code owner September 15, 2024 00:48
@aeisenberg
Copy link
Contributor Author

Thanks, @Daverlo. Working now.

@aeisenberg
Copy link
Contributor Author

@charisk, would you mind taking another look at this? I've made some changes and you can see autofixes are appearing. I rebased in order to remove the intentional linting errors.

@aeisenberg aeisenberg merged commit 11e3aa2 into main Sep 16, 2024
16 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/eslint-sarif branch September 16, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants