feat: add user handle filters (include and exclude) #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
github-actions
bot
added
the
enhancement
Signed-off-by: Adam Setch <[email protected]>
Member
Author
|
@peckjon would the above enhancement cover the use-cases you had in mind? |
|
Love it @setchy ! 🚢 🚀 |
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
afonsojramos
requested changes
Feb 6, 2025
Member
afonsojramos
left a comment
afonsojramos
left a comment
There was a problem hiding this comment.
Looks awesome! Just a couple suggestions
Signed-off-by: Adam Setch <[email protected]>
Co-authored-by: Afonso Jorge Ramos <[email protected]>
Co-authored-by: Afonso Jorge Ramos <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
…/gitify into feat/filter-by-handle
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
|
afonsojramos
added a commit
that referenced
this pull request
Feb 6, 2025
* feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * Update src/renderer/utils/notifications/filters/userType.ts Co-authored-by: Afonso Jorge Ramos <[email protected]> * Update src/renderer/utils/notifications/filters/reason.ts Co-authored-by: Afonso Jorge Ramos <[email protected]> * Merge branch 'main' into feat/filter-by-handle Signed-off-by: Adam Setch <[email protected]> * Merge branch 'main' into feat/filter-by-handle Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> * feat: filter by handles Signed-off-by: Adam Setch <[email protected]> --------- Signed-off-by: Adam Setch <[email protected]> Co-authored-by: Afonso Jorge Ramos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add two new filter options for
include handlesandexclude handles. Closes #1809Also took the opportunity to rework our
hide botsfilter to be a more genericUser Typefilter.For user types, I have
UserandEnterpriseUserAccountunder a commonUserselectionMannequinuser type - didn't think it would be that usefulOrganization, but admittedly I've never seen many of these notifications come through...Updated filter screen (proposed)
Pending items