Update deprecated RN lifecycle methods and fix prop type typo. #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gitim merged 1 commit into gitim:master from cntral:fix_react_native_warnings

Mar 18, 2022

Contributor

jarod-legault commented Mar 1, 2021 •

edited

Loading

Fixes #206.
Fixes #201.
Fixes #193.
Fixes #167.

Updated componentWillMount to componentDidMount and componentWillReceiveProps to componentDidUpdate.

Also fixed typo in SortableList.js: oneOf —> oneOfType. This was causing a warning for an invalid prop type for the decelerationRate prop.


          Update deprecated RN lifecycle methods.

f3c8d69

Also fixed typo: `oneOf` —> `oneOfType`.

jarod-legault mentioned this pull request

Update deprecated RN lifecycle methods. cntral/react-native-sortable-list#1

Merged

runticle commented Feb 2, 2022

Can we merge this? The incorrect props are breaking the tests on my repo!

gitim merged commit b8253e4 into gitim:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment