Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Focus View #216

Closed
wants to merge 2 commits into from
Closed

New Focus View #216

wants to merge 2 commits into from

Conversation

jjsilva4
Copy link
Contributor

@jjsilva4 jjsilva4 commented May 1, 2024

DO NOT MERGE

@gitkraken gitkraken deleted a comment from jjsilva4 May 3, 2024
@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@vicenter-gitkraken
Copy link
Contributor

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@jkelroy jkelroy self-requested a review May 28, 2024 15:37
@jkelroy
Copy link
Contributor

jkelroy commented May 29, 2024

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@jkelroy
Copy link
Contributor

jkelroy commented Jun 10, 2024

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@jkelroy
Copy link
Contributor

jkelroy commented Jun 12, 2024

Hey @jjsilva4, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #216

#216

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@jjsilva4 jjsilva4 added this to the 10.5 release milestone Sep 25, 2024
@jjsilva4 jjsilva4 closed this Sep 26, 2024
@jjsilva4 jjsilva4 deleted the feature branch November 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants