Adds search by URL for GitLab Self Managed to the Launchpad

(#3934)

src/plus/integrations/providers/gitlab.ts

@@ -437,7 +437,13 @@ abstract class GitLabIntegrationBase<
 	}
 
 	protected override getProviderPullRequestIdentityFromMaybeUrl(search: string): PullRequestUrlIdentity | undefined {
-		return getGitLabPullRequestIdentityFromMaybeUrl(search);
+		const identity = getGitLabPullRequestIdentityFromMaybeUrl(search);
+		if (identity == null) return undefined;
+
+		return {
+			...identity,
+			provider: this.id,
+		};
 	}
 }
 

src/plus/integrations/providers/gitlab/__tests__/gitlab.utils.test.ts

@@ -11,7 +11,6 @@ suite('Test GitLab PR URL parsing to identity: getPullRequestIdentityFromMaybeUr
 				: {
 						ownerAndRepo: ownerAndRepo,
 						prNumber: prNumber,
-						provider: 'gitlab',
 				  },
 			`Parse: ${message} (${JSON.stringify(query)})`,
 		);

src/plus/integrations/providers/gitlab/gitlab.utils.ts

@@ -2,7 +2,6 @@
 // That's why this file has been created that can collect more simple functions which
 // don't require Container and can be tested.
 
-import { HostingIntegrationId } from '../../../../constants.integrations';
 import type { PullRequestUrlIdentity } from '../../../../git/models/pullRequest.utils';
 
 export function isMaybeGitLabPullRequestUrl(url: string): boolean {
@@ -11,7 +10,7 @@ export function isMaybeGitLabPullRequestUrl(url: string): boolean {
 
 export function getGitLabPullRequestIdentityFromMaybeUrl(
 	search: string,
-): (PullRequestUrlIdentity & { provider: HostingIntegrationId.GitLab }) | undefined {
+): Omit<PullRequestUrlIdentity, 'provider'> | undefined {
 	let ownerAndRepo: string | undefined = undefined;
 	let prNumber: string | undefined = undefined;
 
@@ -28,7 +27,5 @@ export function getGitLabPullRequestIdentityFromMaybeUrl(
 		}
 	}
 
-	return prNumber != null
-		? { ownerAndRepo: ownerAndRepo, prNumber: prNumber, provider: HostingIntegrationId.GitLab }
-		: undefined;
+	return prNumber != null ? { ownerAndRepo: ownerAndRepo, prNumber: prNumber } : undefined;
 }