Loads promo.json from an s3 bucket #3921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzaytsev
requested review from
eamodio,
d13 and
axosoft-ramint
and removed request for
eamodio,
d13 and
axosoft-ramint
nzaytsev
force-pushed
the
features/21-read-promos-from-s3-bucket
branch
2 times, most recently
from
0817063 to
216de15
Compare
nzaytsev
force-pushed
the
features/21-read-promos-from-s3-bucket
branch
from
216de15 to
fd1215a
Compare
|
Closing in favor of #4034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used env var
GL_PROMO_URIas a reference to a public s3 bucketScreen.Recording.2025-01-13.at.13.13.01.mov
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses