Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitbucket: Launchpad #4099

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Bitbucket: Launchpad #4099

wants to merge 5 commits into from
+451 −16

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Feb 24, 2025 •
edited
Loading

Description

solves #4046

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb marked this pull request as draft February 24, 2025 17:20
@sergeibbb sergeibbb marked this pull request as ready for review February 24, 2025 17:20
@sergeibbb sergeibbb marked this pull request as draft February 24, 2025 17:21
@sergeibbb sergeibbb force-pushed the 4045-home-pr-issue branch 2 times, most recently from 195a7ce to 317ea91 Compare February 25, 2025 14:13
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 0f22513 to aecdedf Compare February 25, 2025 14:21
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from aecdedf to cecf5a7 Compare February 25, 2025 14:22
@sergeibbb sergeibbb force-pushed the 4045-home-pr-issue branch 2 times, most recently from 6844237 to a328685 Compare February 25, 2025 14:28
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
c1f4ecc 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from cecf5a7 to c1f4ecc Compare February 25, 2025 14:31
@sergeibbb sergeibbb marked this pull request as ready for review February 25, 2025 14:31
@sergeibbb sergeibbb linked an issue Feb 25, 2025 that may be closed by this pull request
Bitbucket Cloud: Add Launchpad Support #4046
Open
8 tasks
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
884e933 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
81da91d 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
5e136fb 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
8faf9ed 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 25, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
55cedb2 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from c1f4ecc to 55cedb2 Compare February 25, 2025 14:47
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
36fefdd 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
e04dff2 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 55cedb2 to 8b1c412 Compare February 26, 2025 08:57
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
f11e534 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
9edf0ee 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
8b1c412 
(#4046, #4099)
Base automatically changed from 4045-home-pr-issue to main February 26, 2025 10:52
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
c19777c 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
41e27ee 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
e1d66b1 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
4b0cce4 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 8b1c412 to da1bf24 Compare February 26, 2025 10:54
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
da1bf24 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
38b530b 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
ffac47e 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
df317c3 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from da1bf24 to 95eebe7 Compare February 26, 2025 13:09
sergeibbb added a commit that referenced this pull request Feb 26, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
95eebe7 
(#4046, #4099)
axosoft-ramint
axosoft-ramint reviewed Feb 26, 2025
View reviewed changes
src/plus/integrations/providers/bitbucket.ts
Comment on lines +277 to +297
const repos = await this.getProviderProjectsForResources(session, workspaces);
if (repos == null || repos.length === 0) return undefined;

const api = await this.container.bitbucket;
if (!api) return undefined;
const prsResult = await Promise.allSettled(
repos.map(repo =>
api.getUsersPullRequestsForRepo(
this,
session.accessToken,
user.id,
repo.owner,
repo.name,
this.apiBaseUrl,
),
),
);
return prsResult
.map(r => getSettledValue(r))
.filter(r => r != null)
.flat();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use getPullRequestsForUserAndWorkspace from the shared provider library here, mapping over your workspaces (which is one call per workspace and includes paging) and then converting from ProviderPullRequest to PullRequest with the transformation function instead of doing it ourselves on a per-repo basis?

Copy link
Member Author

@sergeibbb sergeibbb Feb 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axosoft-ramint

Because they use the built-in Bitbucket API call that it returns only PRs where I'm the author, not a reviewer.
image

Another reason is that the shared library doesn't return the information about reviewers and participants:
image

sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
71e584b 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
445c2c9 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
73d86ea 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 95eebe7 to 9e05dc9 Compare February 27, 2025 15:59
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
facfe05 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
9e05dc9 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 9e05dc9 to 4cbc863 Compare February 27, 2025 18:21
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Stops sending request in draftsService with empty entityIds
23c226d 
(#4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Retrieves Bitbucket PRs and shows on the Launchpad
86d6c5e 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Caches and stores Bitbucket inermediate data e.g. workspaces and repos
8878b43 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Retrieves Bitbucket PRs where a user is author or reviewer
a1b8f21 
(#4046, #4099)
sergeibbb added a commit that referenced this pull request Feb 27, 2025
@sergeibbb
Mentions Bitbucket support in the Launchpad in the changelog
4cbc863 
(#4046, #4099)
@sergeibbb sergeibbb force-pushed the 4046-bitbucket-launchpad branch from 4cbc863 to fbba684 Compare February 28, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axosoft-ramint axosoft-ramint axosoft-ramint left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bitbucket Cloud: Add Launchpad Support
2 participants
@sergeibbb @axosoft-ramint