Skip to content

[image-builder] Introduce retry for all resolver requests (timeout 15s, up to 3 times) for all network-related issues #20868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions components/image-builder-api/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ install_dependencies
go_protoc "$COMPONENTS_DIR"
typescript_protoc "$COMPONENTS_DIR"

go generate typescript/util/generate-ws-ready.go

# cd go
pushd go

Expand Down
126 changes: 79 additions & 47 deletions components/image-builder-api/go/imgbuilder.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/image-builder-api/go/imgbuilder_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/image-builder-api/go/mock/mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/image-builder-api/go/subassembly.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/image-builder-api/go/subassembly_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions components/image-builder-api/imgbuilder.proto
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ message BuildSourceDockerfile {
message ResolveBaseImageRequest {
string ref = 1;
BuildRegistryAuth auth = 2;
bool use_retry_client = 3;
}

message ResolveBaseImageResponse {
Expand All @@ -53,6 +54,7 @@ message ResolveBaseImageResponse {
message ResolveWorkspaceImageRequest {
BuildSource source = 1;
BuildRegistryAuth auth = 2;
bool use_retry_client = 3;
}

message ResolveWorkspaceImageResponse {
Expand All @@ -68,6 +70,7 @@ message BuildRequest {
string triggered_by = 4;
string supervisor_ref = 5;
string base_image_name_resolved = 6;
bool use_retry_client = 7;
}

message BuildRegistryAuth {
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 10 additions & 1 deletion components/image-builder-api/typescript/src/imgbuilder_pb.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading