Skip to content

[registry-facade] Properly retry fetching mainfests/config as well #20880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

geropl
Copy link
Member

@geropl geropl commented Jun 6, 2025

Description

Turns out that similarly to #20879 we have a retry mechanism in place, but it does capture this scenario:

And they happen because if io.ReadAll(rc) fails, we do not re-try in any way because:

rc is a httpReadSeeker, so does not only read a body, but might also do new range requests

containerds dockerFetcher does uses http.DefaultClient for subsequent requests, instead of the one we pass into the dockerResolver here 😬 :facepalm-picard:

So the solution to all of those is to implement a retry around the io.ReadAll and .Fetch(...).

Related Issue(s)

Fixes CLC-1365

Related: CLC-195, CLC-1279

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as advertised. Code looks good.

@geropl
Copy link
Member Author

geropl commented Jun 6, 2025

/unhold

@roboquat roboquat merged commit 28be342 into main Jun 6, 2025
61 of 62 checks passed
@roboquat roboquat deleted the gpl/1365-retry-manifest branch June 6, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants