[registry facade] Don't retry requests with error messages that were successful #20889
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: team-experience
team: team-engine
team: team-enterprise
labels
kylos101
reviewed
Jun 9, 2025
Comment on lines
+607
to
+612
| if strings.Contains(err.Error(), "not found") || | ||
| strings.Contains(err.Error(), "invalid argument") || | ||
| strings.Contains(err.Error(), "not implemented") || | ||
| strings.Contains(err.Error(), "unsupported media type") { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Question, non-blocking:
@geropl how did you come up with this list? I ask because depending on the answer, we might want to include others like to cover scenarios like 401 (Unauthorized) and 403 (Forbidden).
Double checking workspace start prior to adding approval.
There was a problem hiding this comment.
@kylos101 Yeah, good call. After sleeping over it, I think it should have been the reverse: default to false, and only retry the exact errors we saw as 500 in the logs. Might even be worth swapping that now... 🤔
kylos101
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #20880: That PR re-tried all requests, even if it was a 404.
This PR introduces a
retryableErrorfunction that excludes non-retryable errors from being retried, fixing this test.Related Issue(s)
Fixes CLC-1419
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold