Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/assign quantifiers only once #222

Merged

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Apr 1, 2022

Short-term workaround to reduce risk of https://github.com/commonsbuild/praise_frontend/issues/101
Resolves https://github.com/CommonsBuild/praise_frontend/issues/101 -- I created a new ticket #223 to consider more "ideal" solutions.

Overview

  • (merged feat/per_period_settings to avoid a tricky merge later)
  • created utilily function verifyAnyPraiseAssigned() to check if any praise within a given period has already been assigned to quantifiers
  • modify period controller assignQuantifiers to throw an error if any praise has been assigned for the period.

@mattyg mattyg requested a review from kristoferlund April 1, 2022 19:43
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And yes, lets make sure we have a more waterproof way to handle concurrent api calls etc in the future.

@kristoferlund kristoferlund merged commit 8e18206 into feat/per_period_settings Apr 4, 2022
@mattyg mattyg deleted the fix/assign_quantifiers_only_once branch April 27, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants