explicitly support current LTS node versions#102
Closed
mansona wants to merge 1 commit into
Closed
Conversation
Owner
|
It's more of a personal choice rather than one dictated by code. I don't like the idea of supporting Maintenance LTS releases as I believe it sets a bad precedent for downstream consumers to hold off major language upgrades. This engine change was explicitly made in a breaking semver update between versions 5 and 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
We recently got a report about an engines warning in ember-cli coming from this package. I can see that you are testing Node 24 and your engine support is set to only Node >= 24 but there is nothing in the code that suggests it can't support all current Node LTS versions
This PR adds those LTS versions to the test matrix and also extends the engine declaration to include them. I have verified that this works by running the CI on my own fork: https://github.com/mansona/isBinaryFile/actions/runs/21331992516?pr=1
Let me know if you have any questions or if you would like me to change anything to help get this landed, thanks 🙇