Skip to content

Implement bool assert #4468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Apr 22, 2025
Merged

Implement bool assert #4468

merged 37 commits into from
Apr 22, 2025

Conversation

GearsDatapacks
Copy link
Member

Closes #4385
I think everything is ready, but I've been working on this on and off for a few weeks now and I can't remember exactly. Let me know if you think something is missing from this!

@GearsDatapacks GearsDatapacks force-pushed the bool-assert branch 2 times, most recently from d021629 to 63d8664 Compare April 18, 2025 21:28
@GearsDatapacks GearsDatapacks mentioned this pull request Apr 18, 2025
Merged
lpil
lpil reviewed Apr 19, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking fantastic! Thank you!!

I've left a bunch of small notes inline.

I'm not 100% sure the exception design is right yet, but I don't think we should let that block this. Can play about with it more before the release.

@GearsDatapacks GearsDatapacks force-pushed the bool-assert branch 2 times, most recently from 8efcdcd to 99aa71c Compare April 21, 2025 09:58
@GearsDatapacks GearsDatapacks mentioned this pull request Apr 21, 2025
Draft
@GearsDatapacks
Implement parsing for bool assert
6eb08d6
@GearsDatapacks
Add parsing for assert message
1a3ce7b
@GearsDatapacks
Type check bool assert
6cfd23f
@GearsDatapacks
Track feature usage of bool assert
ad7823f
@GearsDatapacks
Warn for asserting literal values
f053cf8
@GearsDatapacks
Format bool assert
d8c8bd6
@GearsDatapacks
Implement code generation for bool assert on the javascript target
27bbf5e
@GearsDatapacks
Add tests
6e1ed1e
@GearsDatapacks
Properly wrap asserted expressions in brackets
2214b36
@GearsDatapacks
Fix generation of asserted functions
aaffd75
@GearsDatapacks
Add tests for assert with a message
a51195e
@GearsDatapacks
Generate code for assert on erlang
083638b
@GearsDatapacks
Use atom instead of strings on erlang
96a7271
@GearsDatapacks
Properly generate code for short-circuiting operators when asserting …
9be1b95 
…on erlang
@GearsDatapacks
Don't generate value field if expression is unevaluated
ac677b8
@GearsDatapacks
Properly generate code for short-circuiting operators on js
3b66d5c
@GearsDatapacks
Improve generation of assert || on erlang
6734856
@GearsDatapacks
Improve assert codegen code on erlang
0ac6f6a
@GearsDatapacks
Fix snapshots
e0861bb
@GearsDatapacks
Improve assert codegen code on js
1b436d0
@GearsDatapacks
Fix codegen of assert on erlang
c68fed6
@GearsDatapacks
Add assert integration tests
f66357f
@lpil lpil force-pushed the bool-assert branch 2 times, most recently from b9223f9 to 7769b1d Compare April 22, 2025 12:28
lpil
lpil approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@lpil lpil enabled auto-merge (rebase) April 22, 2025 12:43
@lpil lpil merged commit 00d3aab into gleam-lang:main Apr 22, 2025
12 checks passed
@GearsDatapacks GearsDatapacks deleted the bool-assert branch April 22, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement bool assert
2 participants
@GearsDatapacks @lpil