Skip to content

Conversation

@Flern
Copy link

@Flern Flern commented Mar 28, 2025

Description

Relaxes nullability check for C# 8+ targeting. C# 8 introduced nullable reference types, thereby removing the restriction that only value types can be made nullable.

Related Issue

(#1632)

Motivation and Context

Specifically when using System.Text.Json, the new nullable ignore attribute does not trigger Roslyn warning CS8601, leading to potential runtime null reference exceptions.

Previous Behaviour / Output

Previously, reference types such as string would not include the ? nullability indicator.

New Behaviour / Output

Now, all C# types (reference and value) will include ? when optional, since the serialized data may contain null values for those properties per the specification.

How Has This Been Tested?

Ran before and after examples in a Docker environment.

Screenshots (if appropriate):

image

@TheRubble
Copy link

Hey all....

We've just bumped into this issue due to using the models generated from the schema in a .NET API due to lack of support of nullable reference types the binder fails if the null, this looks like the fix we need.

Is there anything we can do to support this PR?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants