Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): allow passing props to component #309

Merged
merged 1 commit into from
Jun 21, 2023
Merged

feat(dropdown): allow passing props to component #309

merged 1 commit into from
Jun 21, 2023

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Jun 20, 2023

resolves #308, but not sure if it is required

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 32aeef8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/6491910764e6fe0008319a01
😎 Deploy Preview https://deploy-preview-309--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.01 ⚠️

Comparison is base (ba28500) 83.58% compared to head (32aeef8) 83.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   83.58%   83.57%   -0.01%     
==========================================
  Files         123      123              
  Lines       10512    10515       +3     
  Branches      448      448              
==========================================
+ Hits         8786     8788       +2     
- Misses       1726     1727       +1     
Impacted Files Coverage Δ
lib/components/SDropdownSection.vue 91.17% <0.00%> (-2.77%) ⬇️
lib/components/SDropdownSectionComponent.vue 100.00% <100.00%> (ø)
lib/composables/Dropdown.ts 98.65% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 32aeef8
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/64919107f97bfe00076c93bb
😎 Deploy Preview https://deploy-preview-309--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@kiaking kiaking merged commit 6a3f9a1 into main Jun 21, 2023
@kiaking kiaking deleted the fix/308 branch June 21, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dropdown] Pass props to and listen to events from component
2 participants