feat(card): add large size and space option to footer
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sefirot-story ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 83.57% 83.60% +0.02%
==========================================
Files 123 123
Lines 10515 10532 +17
Branches 448 448
==========================================
+ Hits 8788 8805 +17
Misses 1727 1727
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for sefirot-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cuebit
reviewed
Jul 18, 2023
Co-authored-by: Cue <[email protected]>
Co-authored-by: Cue <[email protected]>
cuebit
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
largeoption to<SCard>. Only relevant when using inside<SModal>.Also add
:spaceoption to<SCradFooter>so that it can have the same spacing with<SCardBlock>component. This spacing is needed to align with some of our app design.Also, improved docs a bit.