Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): use :deep instead of :slotted to style elements #557

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Oct 2, 2024

Because seems like :slotted will stop working if we have nested component which very often happens with <STrans>.

<SAlert>
  <!-- This `<p>` becomes font size 16px with `:slotted`. -->
  <STrans lang="en"><p>Lorem ipsum...</p></STrans>
</SAlert>

@kiaking kiaking added the bug label Oct 2, 2024
@kiaking kiaking self-assigned this Oct 2, 2024
@kiaking kiaking requested a review from brc-dd as a code owner October 2, 2024 03:52
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit 166119d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/66fcc395fa0594000872cb35
😎 Deploy Preview https://deploy-preview-557--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit 166119d
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/66fcc395b657a50008338783
😎 Deploy Preview https://deploy-preview-557--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd merged commit edfc823 into main Oct 2, 2024
9 checks passed
@brc-dd brc-dd deleted the fix-alert-deep-style branch October 2, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants