-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix int dtype test #2533
Fix int dtype test #2533
Conversation
This one failed on 32 bit architectures
Thanks for finding this! I suspect this has sneaked in with Numpy 2; just wondering if this still passes with Numpy 1.x on 32bit, but we don't have either in our test matrix. |
data = b'# a, b\n1, 1 \n2, 2 \n3, 3' | ||
with make_file(data, '.csv') as fname: | ||
d = df.load_data(fname) | ||
assert d['a'].dtype == int | ||
assert d['a'].dtype == np.int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be sufficient to check assert d['a'].dtype.kind == 'i'
- as we don't actually care what kind of integer it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this change works with both32 and 64 bit. Thanks for the hint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fix!
@olebole I don't see how the |
During the update of the Debian package for glue I observed one failure when the test runs on a 32-bit machine:
This patch fixes this by explicitly using
np.int64
instead ofint
.