Draft
Conversation
…nhance pool state management
|
hello @HanzCEO sorry for the delayed response on this thread. Is it possible for you to provide get_amount_out and get_amount_in logic too? Currently it is passed. |
Author
Hi, this integration is still in draft. I have many changes that haven't been pushed yet. This PR is not ready for review. |
Author
|
Maybe you meant to review #26 (BrownFi)? @eshu-manohare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol Information
Summary of Integration
Provide a brief overview of your integration:
Implementation Details
Execution Functions Required
Functions Implemented
get_amount_out()- Token2token swap and liquidity provision token "swap"get_amount_in()- Token2token swap and liquidity provision token "swap"get_apy()- Calculates dilluted 24hrs yields that is compounded for 365 daysget_tvl()- Assets inside Core contractDynamic States Required for AMM Calculations
${token_address_lowercase}_balance- Obtained fromtoken_address_lowercase.balanceOf(address(Core))Static States Required for AMM Calculations
core_address-0xe0e0e08a6a4b9dc7bd67bcb7aade5cf48157d444Dependencies
N/A
Other Requirements
Test Results
Click to view test results