Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template: GlueX Liquidity Module Integration
Protocol Information
Summary of Integration
Provide a brief overview of your integration:
A sample protocol for Market maker integration
Market maker private liquidity
It supports 1inch/cowswap/0x RFQ
Implementation Details
Execution Functions Required
List all execution functions that GlueX needs to interact with your protocol, including:
RFQ function name on contract eg: settle/swap
RFQ input params like sell_token, buy_token etc
RFQ settlement/router contract address
Functions Implemented
get_sell_quote():Fetch quote from makert maker SellQuote API with inputs as input token, output token, input_amount, and user address.
get_buy_quote():Fetch quote from makert maker BuyQuote API with inputs as input token, output token, output_amount, and user address.
Dynamic States Required for AMM Calculations
N/A
Static States Required for AMM Calculations
Specify any on-chain values that remain constant such as:
Dependencies
List any external dependencies (APIs, data sources, libraries). If none, state N/A.
Other Requirements
API Keys:
Special Access Requirements: Any required permissions, whitelisting, or approvals.
Test Results
Provide details of tests performed, including: