This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Make script more resilient, lint, fix shellcheck warnings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because a server may have a non-primary IP as the first index in `MY_IPS`, e.g. when the server has IP addresses on multiple networks.
As ls will exit with return != 0 when file is not found
|
Great Work, @kalebskeithley Do you know if storhaug will be replaced? |
ryno83
reviewed
Aug 15, 2019
| } | ||
| } | ||
| EOF | ||
|
|
||
| exp_id=$(ls -1 /run/gluster/shared_storage/nfs-ganesha/exports/export.*.conf | wc -l) | ||
| exp_id=$(find /run/gluster/shared_storage/nfs-ganesha/exports -name 'export.*.conf' | wc -l) |
There was a problem hiding this comment.
I didn't test your code but did you think about this issue #26 ?
There was a problem hiding this comment.
Nope, hadn't looked through the issues. I see that it was just merged, I'll rebase my PR against master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a whole bunch of assorted fixes for storhaug in this draft PR. Is that something you'd be interested in merging?
My intention is to make the following changes:
set -euo pipefail(errexit,nounset,pipefail)${#var}for counting items in arrays instead of looping overevalfor creating arrays in favor ofdeclarefindinstead oflsI've marked this PR as draft because it's currently only big PR that both lints/refactors and changes functionality. I'd be happy to split it up into multiple PRs if you'd like.