Add support for WebVTT timeframes in MS Teams' non-compliant format #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Teams generates .VTT transcript files for all recorded meetings. Unfortunately, it appears those files are not spec-conforming (shocker!), because they don't 0-pad any of the fields to their respective sizes (3 for milliseconds, 2 for everything else).
Pragmatically speaking, it would help for webvtt-py to support this, since it doesn't harm its ability to correctly and safely parse conforming ones. This patch does that, and adds a testcase for a representative Teams VTT.
Closes #44 among many others, I'm sure.