Add better completion - #233
Conversation
4cb1266 to
d28c3b7
Compare
|
Thanks for this — positional-argument completion is a genuinely useful addition, and the core mechanism (reading resource/pod/namespace names out of the must-gather) works well. I built the branch and tests pass. Before this can be merged, though, I'd like to ask for a few changes: 1. Fix the
2. Please remove
3. Split the gofmt/whitespace reformatting into a separate PR A large part of the diff is tabs-vs-spaces reformatting across files unrelated to completion (etcd tests rewritten wholesale, license headers, 4. Minor code-consistency cleanups
Happy to help review once the |
So
omcdoes not currently offer completion for positional arguments such as:omc get <pod> <pod_name>This PR implements that. A lot of changes related to whitespace noise is because, we didn't seem to be using
gofmtstandards previously and bunch of files were using four spaces, instead of tab.gofmtuses tabs. Let me know if that is an issue.Disclaimer: Most of the completion code however was generated by Claude.