Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to new pamqp #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

galuszkak
Copy link

No description provided.

@galuszkak
Copy link
Author

Hi @gmr ,

This is half way PR. I can't figure out why integration tests are failing. On Python 3.6 and 3.7 they are hanging. In 3.8 there is an exception which I can't figure out.

Any help appreciated.

This is related to #125

@galuszkak
Copy link
Author

Travis is available here:
https://travis-ci.org/github/gmr/rabbitpy/builds/736674037

@galuszkak
Copy link
Author

I dig a little more and this happens when method self.channel.close()

@galuszkak
Copy link
Author

OK I fixed problem with channel and connection closing.

Unfortunetly I don't know how to solve problem with sending messages.

I think something weird is happening in pamqp because if message_id is bytes then:

lib/python3.8/site-packages/pamqp/encode.py", line 352, in _string
    raise TypeError('str required, received {}'.format(type(value)))

But if it's a string:

  File "/Users/galuszkak/Projects/rabbitpy/.tox/py38/lib/python3.8/site-packages/pamqp/frame.py", line 101, in _marshal
    return b''.join([
TypeError: sequence item 1: expected a bytes-like object, str found

So I'm not sure why is that, but in any of cases, this just doesn't work. I think it's pamqp bug, but I'm not entirely sure.

@gmr could you help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant