chore: change proto generate script to apply compatibility patch #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeronimoalbi
commented
Aug 19, 2025
| # This is a short term solution that potentially requires maintaining the patch updated. | ||
| if [ $? -eq 0 ]; then | ||
| # First prettify generated code to allow the patch to be applied | ||
| ./node_modules/.bin/prettier --write ${OUT_DIR}/gno/vm.ts && \ |
There was a problem hiding this comment.
The proto generated code seems to have been prettified, without this extra step the changes from #184 don't apply successfully right after the gno/vm.ts file is generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #184
PR changes the proto generate script to apply the changes from #184 to the generated files.
If merged, this is intended as a short term solution until the underlying Amino compatibility issue is discussed and solved.
The caveat of this patch based approach is that it might require some added effort to keep the patch file updated.